Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about encrypted_ch and encrypted_ch_inner #301

Closed
D-Sinus opened this issue Sep 8, 2020 · 2 comments · Fixed by #302
Closed

Question about encrypted_ch and encrypted_ch_inner #301

D-Sinus opened this issue Sep 8, 2020 · 2 comments · Fixed by #302

Comments

@D-Sinus
Copy link
Contributor

D-Sinus commented Sep 8, 2020

While reading the draft, I'm confused with ClientEncryptedCH structure.

Section : The "encrypted_client_hello" extension says...

    struct {
       HpkeCipherSuite cipher_suite;
       opaque config_id<0..255>;
       opaque enc<1..2^16-1>;
       opaque encrypted_ch<1..2^16-1>;
    } ClientEncryptedCH;

enc : The HPKE encapsulated key, used by servers to decrypt the corresponding encrypted_ch field.
encrypted_ch : The serialized and encrypted ClientHelloInner structure, encrypted using HPKE as described in {{send-ech}}.

and Section : Sending an encrypted ClientHello says...

The encrypted ClientHello value is then computed as:

    encrypted_ch = context.Seal("", ClientHelloInner)

Cause output of the context.Seal() function is ciphertext output of AEAD encryption (According to draft-irtf-cfrg-hpke-05),
I think encrypted_ch has only ciphertext value of the ClientHelloInner, not the enc value.
But the same section also says...

encrypted_ch contains the HPKE encapsulated key (enc) and the ClientHelloInner ciphertext (encrypted_ch_inner).

Q. Does encrypted_ch have enc and encrypted_ch_inner?
Or it just has the ciphertext of ClientHelloInner and encrypted_ch_inner is just mistype?

@cjpatton
Copy link
Contributor

cjpatton commented Sep 8, 2020

Nice catch! encrypted_ch should just be the AEAD ciphertext. The following text is wrong:

  • encrypted_ch contains the HPKE encapsulated key (enc) and the ClientHelloInner
    ciphertext (encrypted_ch_inner).

It should be:

  • encrypted_ch contains the AEAD-encrypted ClientHelloInner.

cc/ @chris-wood

@D-Sinus
Copy link
Contributor Author

D-Sinus commented Sep 10, 2020

OK, there's no encrypted_ch_inner.. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants