editorial/nit fixes from AD evaluation #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaduk
commented
Oct 28, 2020
| @@ -157,7 +157,7 @@ negotiate a fresh session (full handshake). | |||
|
|
|||
| resumption_count | |||
| : The number of tickets desired by the client when the server is willing to | |||
| resume using the presented ticket. | |||
| resume using a ticket presented in this ClientHello. | |||
There was a problem hiding this comment.
My initial change here was to add a parenthetical "if any", since there may not be any presented tickets. On the other hand, a quick read of 8446 didn't find any limitation on "at most one ticket in a given 'pre_shared_key' extension", so in principle there is not a single specific "presented ticket", and the "if any" parenthetical seems to not flow very well anymore after this change.
DavidSchinazi
approved these changes
Oct 28, 2020
chris-wood
approved these changes
Oct 31, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully nothing too outlandish in here