Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection ID appears in the MAC twice #8

Closed
martinthomson opened this issue Jul 10, 2018 · 1 comment
Closed

Connection ID appears in the MAC twice #8

martinthomson opened this issue Jul 10, 2018 · 1 comment

Comments

@martinthomson
Copy link
Contributor 

         MAC(MAC_write_key, DTLSCompressed.epoch +
                               DTLSCompressed.sequence_number +
                               DTLSCompressed.type +
                               DTLSCompressed.version +
                               connection_id + // New field
                               cid_length +        // New input
                               cid +               // New input
                               DTLSCompressed.length +
                               DTLSCompressed.fragment);

I assume that cid and connection_id are the same thing.
@thomas-fossati
Copy link
Collaborator

Yep. This was fixed in #6, but that PR is still un-merged.

@ekr ekr closed this as completed Oct 21, 2018
ekr added a commit that referenced this issue Oct 21, 2018
@ekr
Remove duplicate CID in MAC. Fixes #8
fdecc3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @ekr @thomas-fossati