LaTeX: Add font scaling option to package #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Font definition files (`*.fd`) are modified so that they can be scaled by a factor as specified by the command `\fontstlwg@scale` if it is defined. The syntax used is according to the documentation [fntguide](https://www.ctan.org/pkg/fntguide?lang=en). * The LaTeX package `fonts-tlwg.sty` is modified so that the command `\fontstlwg@scale` can be set through package option `scaled`. It is documented in the file `README.latex`. * The package [xkeyval](https://www.ctan.org/pkg/xkeyval?lang=en) is used to allow this package to accept a value for the scaling factor, hence why `\DeclareOptionX` is used instead of `\DeclareOption`. * Tests are added to demonstrate how the scaling option can be used.
Contributor
|
Thank you for your work! Before I try it, I think the "scaled" option should be "scale" (without "d") to be more intuitive. It's the common option between opensans ("scale") and roboto ("scaled" or "scale"). And users who are familiar with \includegraphics command should be already familiar with its "scale" option. What do you think? |
Contributor
|
Pull request merged, with option 'scaled' renamed to 'scale'. Thank you very much for your contribution! |
Contributor
Author
|
I agree that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
When fonts in this package is used in conjunction with other Latin fonts, there may be discrepancies in font sizes. If we can scale the size of fonts in this package, such issue would be solved. This idea is inspired by many font packages such as opensans and roboto, etc.
Changes:
*.fd) are modified so that they can be scaled by a factor as specified by the command\fontstlwg@scaleif it is defined. The syntax used is according to the documentation fntguide.fonts-tlwg.styis modified so that the command\fontstlwg@scalecan be set through package optionscaled. It is documented in the fileREADME.latex.\DeclareOptionXis used instead of\DeclareOption.