New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect keys in Pattachote layout #1

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
2 participants
@sirn
Contributor

sirn commented Dec 28, 2016

I'm a Pattachote typist and recently noticed ibus-libthai got few keys incorrect mapped in Pattachote layout and have proceed to patch it to the correct key. This patch changes the key in the following position in Pattachote layout:

  • Shift-A position / was 0xEA (Mai Tri), should be 0xEB (Mai Chattawa)
  • Shift-D position / was 0xD2 (Sara Aa), should be 0xD3 (Sara Am)

Without this patch, it's not possible to Pattachote user to type Mai Chattawa and Sara Am. Not sure if I should patch somewhere else too (keycode_to_tis that calls thai_map_keycode seems to be unused?) but the keys seems to be working now from my local testing.

Fix incorrect keys in Pattachote layout.
0xEA (Mai Tri) -> 0xEB (Mai Chattawa)
0xD2 (Sara Aa) -> 0xD3 (Sara Am)
@thep

This comment has been minimized.

Show comment
Hide comment
@thep

thep Dec 29, 2016

Contributor

Thank you for your pull request. Yes, from a quick check, the two characters seem to be missing from pattachote_keycode_map, which should be fix.

Regarding the other place, it's keyval_to_tis() that has not got called. It's an old mapping method based on QWERTY character conversion, which can be confusing when mixed with XKB key translation. I changed it to direct keyboard scan code mapping in some version, while still keeping the old code as a spare part. But thinking it twice, I should just remove the unused code anyway.

In short, no other change is needed. I'll re-check your patch soon, before merging it.

Contributor

thep commented Dec 29, 2016

Thank you for your pull request. Yes, from a quick check, the two characters seem to be missing from pattachote_keycode_map, which should be fix.

Regarding the other place, it's keyval_to_tis() that has not got called. It's an old mapping method based on QWERTY character conversion, which can be confusing when mixed with XKB key translation. I changed it to direct keyboard scan code mapping in some version, while still keeping the old code as a spare part. But thinking it twice, I should just remove the unused code anyway.

In short, no other change is needed. I'll re-check your patch soon, before merging it.

@thep thep merged commit 6c3ff3a into tlwg:master Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment