Fix incorrect keys in Pattachote layout#1
Merged
Merged
Conversation
0xEA (Mai Tri) -> 0xEB (Mai Chattawa) 0xD2 (Sara Aa) -> 0xD3 (Sara Am)
Contributor
|
Thank you for your pull request. Yes, from a quick check, the two characters seem to be missing from Regarding the other place, it's In short, no other change is needed. I'll re-check your patch soon, before merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a Pattachote typist and recently noticed ibus-libthai got few keys incorrect mapped in Pattachote layout and have proceed to patch it to the correct key. This patch changes the key in the following position in Pattachote layout:
0xEA (Mai Tri), should be0xEB (Mai Chattawa)0xD2 (Sara Aa), should be0xD3 (Sara Am)Without this patch, it's not possible to Pattachote user to type Mai Chattawa and Sara Am. Not sure if I should patch somewhere else too (
keycode_to_tisthat callsthai_map_keycodeseems to be unused?) but the keys seems to be working now from my local testing.