Fix ctype usage to be safe #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argment of ctype(3) functions is of type int, but expected as either "unsigned char" or EOF. So value of type "char" must be cast to "unsigned char" to pass such functions, or it may result in unwanted behaviour, especially for the case using non-ascii chars in char type value on platforms that "char" is "signed char" type.
Author
|
f1479aa ,same diff, different author, over 2 years later. |
Contributor
So sorry for missing this issue. :-( My recent life granted me little time to work on github projects, which I'm trying to manage to get more time. Thank you for your patch and please allow me to mention you in the NEWS file in the next release. |
Author
|
Don't worry about it, It's OK. Best to you as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argment of ctype(3) functions is of type int, but expected as
either "unsigned char" or EOF.
So value of type "char" must be cast to "unsigned char" to pass such
functions, or it may result in unwanted behaviour, especially for the
case using non-ascii chars in char type value on platforms that "char"
is "signed char" type.