Acl #5

Closed
wants to merge 22 commits into
from

Conversation

Projects
None yet
4 participants
@agborkowski

DRAFT prototype of ACL from CakePHP any suggestion ?

@rich97

This comment has been minimized.

Show comment Hide comment
@rich97

rich97 Aug 29, 2011

Doesn't this break Lithium QA? The coding standards say you should use one tab for indentation. Not two spaces.

Aside from that, I don't understand this current trend of using two spaces that I keep seeing (node.js people use it too...) It should be 4 IMO.

I like this adapter idea. I haven't had a chance to review the code yet. But it's nice to have the option of using a relational DB to manage ACL. Though document DBs do it better. ;)

Edit: Also, I think this is a slightly old version of li3_access you seem to be using. I've made some changes to it myself, though it hasn't been pulled into the master yet.

rich97 commented on 18c44c9 Aug 29, 2011

Doesn't this break Lithium QA? The coding standards say you should use one tab for indentation. Not two spaces.

Aside from that, I don't understand this current trend of using two spaces that I keep seeing (node.js people use it too...) It should be 4 IMO.

I like this adapter idea. I haven't had a chance to review the code yet. But it's nice to have the option of using a relational DB to manage ACL. Though document DBs do it better. ;)

Edit: Also, I think this is a slightly old version of li3_access you seem to be using. I've made some changes to it myself, though it hasn't been pulled into the master yet.

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Aug 30, 2011

Owner

@rich97 i use TABS !! sometimes i miss copy&&paste code. Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces... in code snippiest

i use old version, because when i start coding i miss ur updates, after many changes i cant change to ur never version becouse u change api and i havent test coverage for my classes ( i can not write test)

in future i think document will be gr8 idea... but i dont know how fast is binary trees search...

Owner

agborkowski replied Aug 30, 2011

@rich97 i use TABS !! sometimes i miss copy&&paste code. Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces... in code snippiest

i use old version, because when i start coding i miss ur updates, after many changes i cant change to ur never version becouse u change api and i havent test coverage for my classes ( i can not write test)

in future i think document will be gr8 idea... but i dont know how fast is binary trees search...

This comment has been minimized.

Show comment Hide comment
@rich97

rich97 Aug 30, 2011

Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces

Hehe, sorry I haven't downloaded the code yet, GitHub tricked me. I thought they would show tabs as 4 spaces. ^_^

i use old version, because when i start coding i miss ur updates

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

Is this draft basically working? If it is I can add some tests and write some documentation in the README when I have some spare time.

Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces

Hehe, sorry I haven't downloaded the code yet, GitHub tricked me. I thought they would show tabs as 4 spaces. ^_^

i use old version, because when i start coding i miss ur updates

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

Is this draft basically working? If it is I can add some tests and write some documentation in the README when I have some spare time.

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Aug 30, 2011

Owner

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

sounds gr8, when i finish acl branch i merge it witch ur changes from ur master..

Is this draft basically working?

works well:
find node Aros,Acos in binary tree
add node Aros, Acos (behavior, today i change it to works witch li3_behavior)
todos:
complete check permision Aros have permission to Acos..
[allow, deny] permission
risk:
still don know how habtm will work in li3 i need this relation for Aro <- Permission -> Aco

If it is I can add some tests and write some documentation in the README when I have some spare time.

sounds gr8 in this week i'll close li3_acces [acl] and merge with ur master

Owner

agborkowski replied Aug 30, 2011

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

sounds gr8, when i finish acl branch i merge it witch ur changes from ur master..

Is this draft basically working?

works well:
find node Aros,Acos in binary tree
add node Aros, Acos (behavior, today i change it to works witch li3_behavior)
todos:
complete check permision Aros have permission to Acos..
[allow, deny] permission
risk:
still don know how habtm will work in li3 i need this relation for Aro <- Permission -> Aco

If it is I can add some tests and write some documentation in the README when I have some spare time.

sounds gr8 in this week i'll close li3_acces [acl] and merge with ur master

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Sep 1, 2011

Owner

ok i have done full check permision Aro->Aco... ill make readme

Owner

agborkowski replied Sep 1, 2011

ok i have done full check permision Aro->Aco... ill make readme

This comment has been minimized.

Show comment Hide comment
@rich97

rich97 Sep 12, 2011

OK, I'll see if I can get to it in the coming week. Though no promises as I'm very busy right now.

OK, I'll see if I can get to it in the coming week. Though no promises as I'm very busy right now.

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Sep 12, 2011

Owner

make push my acl to ur master of li3_acces or u get my changes..

Owner

agborkowski replied Sep 12, 2011

make push my acl to ur master of li3_acces or u get my changes..

@agborkowski

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Aug 30, 2011

Owner

i do not understand why use li3_acces\models\{Aros,Acos} dont work... and i must use libraries::locate... @nateabele any suggestion ?

i do not understand why use li3_acces\models\{Aros,Acos} dont work... and i must use libraries::locate... @nateabele any suggestion ?

@agborkowski

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Aug 30, 2011

Owner

now acl behavior work with li3_behavior

Owner

agborkowski commented on 6e47389 Aug 30, 2011

now acl behavior work with li3_behavior

@nateabele

This comment has been minimized.

Show comment Hide comment
@nateabele

nateabele Oct 20, 2011

Collaborator

I merged my changes into @tmaiaroto's master branch, so you can fix the commit range based on that. Also, can we call the table permissions instead of aros_acos?

Collaborator

nateabele commented Oct 20, 2011

I merged my changes into @tmaiaroto's master branch, so you can fix the commit range based on that. Also, can we call the table permissions instead of aros_acos?

@agborkowski agborkowski reopened this Oct 20, 2011

@agborkowski

This comment has been minimized.

Show comment Hide comment
@agborkowski

agborkowski Oct 20, 2011

yes sure permission is ok, 'so you can fix the commit range based on that' i dont know within range use... i never do that

yes sure permission is ok, 'so you can fix the commit range based on that' i dont know within range use... i never do that

@Ciaro

This comment has been minimized.

Show comment Hide comment
@Ciaro

Ciaro Mar 7, 2012

Contributor

@agborkowski I suggest you close both your pull requests, add your acl adapter to the latest master and make a new pull request with valid tests and some documentation. Agreeing with @nateabele on renaming the table to 'permissions'...

Contributor

Ciaro commented Mar 7, 2012

@agborkowski I suggest you close both your pull requests, add your acl adapter to the latest master and make a new pull request with valid tests and some documentation. Agreeing with @nateabele on renaming the table to 'permissions'...

@agborkowski agborkowski deleted the agborkowski:acl branch Nov 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment