add get method to acces adapter for get permission for rows of model #7

Open
wants to merge 31 commits into
from

Conversation

Projects
None yet
3 participants

add some sql test (in future i add sql files for make test)

Andrzej Grzegorz Borkowski and others added some commits Aug 2, 2011

Andrzej Grzegorz Borkowski QA code fix 18c44c9
Andrzej Grzegorz Borkowski init acl 2f52b8e
Andrzej Grzegorz Borkowski debug acl::node 4c1538f
Andrzej Grzegorz Borkowski node fixes and convert for li3 and php 5.3 86f14b1
@agborkowski agborkowski change models namespaces d66193e
@agborkowski agborkowski Revert "change models namespaces"
This reverts commit d66193e.
d0a98d8
@agborkowski agborkowski acl behavior init, rebase models 092d4e2
@agborkowski agborkowski ^ delegate triggers
^ many fixes
13cfa08
@agborkowski agborkowski * QA code
* tests
* add Libraries dynamicly load in behaviors
3a329dd

rich97 commented on 18c44c9 Aug 29, 2011

Doesn't this break Lithium QA? The coding standards say you should use one tab for indentation. Not two spaces.

Aside from that, I don't understand this current trend of using two spaces that I keep seeing (node.js people use it too...) It should be 4 IMO.

I like this adapter idea. I haven't had a chance to review the code yet. But it's nice to have the option of using a relational DB to manage ACL. Though document DBs do it better. ;)

Edit: Also, I think this is a slightly old version of li3_access you seem to be using. I've made some changes to it myself, though it hasn't been pulled into the master yet.

Owner

agborkowski replied Aug 30, 2011

@rich97 i use TABS !! sometimes i miss copy&&paste code. Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces... in code snippiest

i use old version, because when i start coding i miss ur updates, after many changes i cant change to ur never version becouse u change api and i havent test coverage for my classes ( i can not write test)

in future i think document will be gr8 idea... but i dont know how fast is binary trees search...

Github dont show whitespaces, gr8 idea is write to developers about shows whitespaces

Hehe, sorry I haven't downloaded the code yet, GitHub tricked me. I thought they would show tabs as 4 spaces. ^_^

i use old version, because when i start coding i miss ur updates

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

Is this draft basically working? If it is I can add some tests and write some documentation in the README when I have some spare time.

Owner

agborkowski replied Aug 30, 2011

That's OK. In the newest version I changed the API back to the way it was, the only difference is the $user parameter has been changed to $resource.

sounds gr8, when i finish acl branch i merge it witch ur changes from ur master..

Is this draft basically working?

works well:
find node Aros,Acos in binary tree
add node Aros, Acos (behavior, today i change it to works witch li3_behavior)
todos:
complete check permision Aros have permission to Acos..
[allow, deny] permission
risk:
still don know how habtm will work in li3 i need this relation for Aro <- Permission -> Aco

If it is I can add some tests and write some documentation in the README when I have some spare time.

sounds gr8 in this week i'll close li3_acces [acl] and merge with ur master

Owner

agborkowski replied Sep 1, 2011

ok i have done full check permision Aro->Aco... ill make readme

OK, I'll see if I can get to it in the coming week. Though no promises as I'm very busy right now.

Owner

agborkowski replied Sep 12, 2011

make push my acl to ur master of li3_acces or u get my changes..

i do not understand why use li3_acces\models\{Aros,Acos} dont work... and i must use libraries::locate... @nateabele any suggestion ?

Owner

agborkowski commented on 6e47389 Aug 30, 2011

now acl behavior work with li3_behavior

Contributor

joedevon commented Dec 13, 2011

@rich97
QUOTE:
"Edit: Also, I think this is a slightly old version of li3_access you seem to be using. I've made some changes to it myself, though it hasn't been pulled into the master yet."

Wait wait wait!! This is a fork??? Where's the original?
Or the one being most maintained?

Contributor

rich97 commented Dec 14, 2011

No, this is the original. I re-did the AuthRBAC adapter and fixed some tests. If I'm correct I think my fork is the most up-to-date, unless Tom has made some changes I am unaware of. He just hasn't gotten round to pulling my changes in yet. I can't link as I'm on my phone but check out the pull requests to see what's going on.

Contributor

joedevon commented Dec 14, 2011

I see you've added some very helpful comments. I'm not seeing how to switch my fork to inherit or merge in yours. Hmm.

Contributor

rich97 commented Dec 14, 2011

I think that's my responsibility to be honest. Due to work obligations I haven't been able to keep up with li3_access development (I really miss developing with Lithium.) As long as your changes are merged into master I'll do the leg work to update my fork. Though I am very busy right now so it's not going to be soon. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment