Skip to content
Commits on Jul 20, 2011
  1. @davem330 @larsclausen

    pppoe: Must flush connections when MAC address changes too.

    davem330 committed with larsclausen Jul 18, 2011
    Kernel bugzilla: 39252
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
  2. @congwang @larsclausen

    include/linux/sdla.h: remove the prototype of sdla()

    congwang committed with larsclausen Jul 16, 2011
    `make headers_check` complains that
    
    linux-2.6/usr/include/linux/sdla.h:116: userspace cannot reference
    function or variable defined in the kernel
    
    this is due to that there is no such a kernel function,
    
    void sdla(void *cfg_info, char *dev, struct frad_conf *conf, int quiet);
    
    I don't know why we have it in a kernel header, so remove it.
    
    Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  3. @JoePerches @larsclausen

    tulip: dmfe: Remove old log spamming pr_debugs

    JoePerches committed with larsclausen Jul 18, 2011
    Commit 726b65a ("tulip: Convert uses of KERN_DEBUG") enabled
    some old previously inactive uses of pr_debug converted by
    commit dde7c8e ("tulip/dmfe.c: Use dev_<level> and pr_<level>").
    
    Remove these pr_debugs.
    
    Signed-off-by: Joe Perches <joe@perches.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  4. @larsclausen

    si4713-i2c: avoid potential buffer overflow on si4713

    Mauro Carvalho Chehab committed with larsclausen Jul 17, 2011
    While compiling it with Fedora 15, I noticed this issue:
    
      inlined from ‘si4713_write_econtrol_string’ at drivers/media/radio/si4713-i2c.c:1065:24:
      arch/x86/include/asm/uaccess_32.h:211:26: error: call to ‘copy_from_user_overflow’ declared with attribute error: copy_from_user() buffer size is not provably correct
    
    Cc: stable@kernel.org
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Acked-by: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
    Acked-by: Eduardo Valentin <edubezval@gmail.com>
    Reviewed-by: Eugene Teo <eugeneteo@kernel.sg>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  5. @broonie @larsclausen

    ASoC: Correct WM8994 MICBIAS supply widget hookup

    broonie committed with larsclausen Jul 14, 2011
    The WM8994 and WM8958 series of devices have two MICBIAS supplies rather
    than one, the current widget actually manages the microphone detection
    control register bit (which is managed separately by the relevant API).
    
    Fix this, hooking the relevant supplies up to the MICBIAS1 and MICBIAS2
    widgets.
    
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: stable@kernel.org
  6. @broonie @larsclausen

    ASoC: Fix shift in WM8958 accessory detection default implementation

    broonie committed with larsclausen Jul 15, 2011
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Cc: stable@kernel.org
  7. @morimoto @larsclausen

    ASoC: sh: fsi-hdmi: fixup snd_soc_card name

    morimoto committed with larsclausen Jul 5, 2011
    it shouldn't contain space letters and
    special letters like parentheses.
    
    aplay will be "Segmentation fault" without this patch
    special thanks to Takashi.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Acked-by: Liam Girdwood <lrg@ti.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  8. @morimoto @larsclausen

    ASoC: sh: fsi-da7210: fixup snd_soc_card name

    morimoto committed with larsclausen Jul 5, 2011
    it shouldn't contain space letters and
    special letters like parentheses.
    
    aplay will be "Segmentation fault" without this patch.
    special thanks to Takashi.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Acked-by: Liam Girdwood <lrg@ti.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  9. @morimoto @larsclausen

    ASoC: sh: fsi-ak4642: fixup snd_soc_card name

    morimoto committed with larsclausen Jul 5, 2011
    it shouldn't contain space letters and
    special letters like parentheses.
    
    aplay will be "Segmentation fault" without this patch.
    special thanks to Takashi.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Acked-by: Liam Girdwood <lrg@ti.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  10. @larsclausen

    hppfs_lookup(): don't open-code lookup_one_len()

    Al Viro committed with larsclausen Jul 17, 2011
    ... and it's getting it wrong, too - missing ->d_revalidate() calls when
    it's dealing with filesystem (procfs) that has non-trivial ->d_revalidate()...
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  11. @larsclausen

    hppfs: fix dentry leak

    Al Viro committed with larsclausen Jul 17, 2011
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  12. @larsclausen

    cramfs: get_cramfs_inode() returns ERR_PTR() on failure

    Al Viro committed with larsclausen Jul 17, 2011
    ... and we want to report these failures in ->lookup() anyway.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  13. @larsclausen

    ufs should use d_splice_alias()

    Al Viro committed with larsclausen Jul 17, 2011
    it's NFS-exportable, so...
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  14. @larsclausen

    fix exofs ->get_parent()

    Al Viro committed with larsclausen Jul 8, 2011
    NULL is not a possible return value for that method, TYVM...
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  15. @larsclausen

    ceph analog of cifs build_path_from_dentry() race fix

    Al Viro committed with larsclausen Jul 16, 2011
    ... unfortunately, cifs bug got copied.  Fix is essentially the same.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  16. @larsclausen

    cifs: build_path_from_dentry() race fix

    Al Viro committed with larsclausen Jul 16, 2011
    deal with d_move() races properly; rename_lock read-retry loop,
    rcu_read_lock() held while walking to root, d_lock held over
    subtraction from namelen and copying the component to stabilize
    ->d_name.
    
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  17. @larsclausen

    hwmon: (max1111) Fix race condition causing NULL pointer exception

    Pavel Herrmann committed with larsclausen Jul 17, 2011
    spi_sync call uses its spi_message parameter to keep completion information,
    using a drvdata structure is not thread-safe. Use a mutex to prevent
    multiple access to shared driver data.
    
    Signed-off-by: Pavel Herrmann <morpheus.ibis@gmail.com>
    Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    Acked-by: Marek Vasut <marek.vasut@gmail.com>
    Acked-by: Cyril Hrubis <metan@ucw.cz>
    Tested-by: Stanislav Brabec <utx@penguin.cz>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Cc: stable@kernel.org
  18. @larsclausen

    hwmon: (it87) Fix label group removal

    Jean Delvare committed with larsclausen Jul 17, 2011
    A copy-and-paste error caused it87_attributes_vid to be referenced
    where it87_attributes_label should be. Thankfully the group is only
    used for attribute removal, not attribute creation, so the effects of
    this bug are limited, but let's fix it still.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Cc: stable@kernel.org
    Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
  19. @tettamanti @larsclausen

    hwmon: (asus_atk0110) Fix memory leak

    tettamanti committed with larsclausen Jul 17, 2011
    The object returned by atk_gitm is dynamically allocated and must be
    freed.
    
    Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Cc: stable@kernel.org
  20. @larsclausen

    [CIFS] update cifs to version 1.74

    Steve French committed with larsclausen Jul 12, 2011
    Signed-off-by: Steve French <sfrench@us.ibm.com>
  21. @larsclausen

    [CIFS] update limit for snprintf in cifs_construct_tcon

    Steve French committed with larsclausen Jul 12, 2011
    In 34c8790 "Shrink stack space usage in cifs_construct_tcon" we
    change the size of the username name buffer from MAX_USERNAME_SIZE
    (256) to 28.  This call to snprintf() needs to be updated as well.
    Reported by Dan Carpenter.
    
    Reviewed-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
  22. @shirishpargaonkar @larsclausen

    cifs: Fix signing failure when server mandates signing for NTLMSSP

    shirishpargaonkar committed with larsclausen Jul 10, 2011
    When using NTLMSSP authentication mechanism, if server mandates
    signing, keep the flags in type 3 messages of the NTLMSSP exchange
    same as in type 1 messages (i.e. keep the indicated capabilities same).
    
    Some of the servers such as Samba, expect the flags such as
    Negotiate_Key_Exchange in type 3 message of NTLMSSP exchange as well.
    Some servers like Windows do not.
    
    https://bugzilla.samba.org/show_bug.cgi?id=8212
    
    Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@gmail>
    Acked-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
  23. @larsclausen

    Bluetooth: Fix crash with incoming L2CAP connections

    Ilia Kolomisnky committed with larsclausen Jul 15, 2011
    Another regression fix considering incomming l2cap connections with
    defer_setup enabled. In situations when incomming connection is
    extracted with l2cap_sock_accept, it's bt_sock info will have
    'parent' member zerroed, but 'parent' may be used unconditionally
    in l2cap_conn_start() and l2cap_security_cfm() when defer_setup
    is enabled.
    
    Backtrace:
    [<bf02d5ac>] (l2cap_security_cfm+0x0/0x2ac [bluetooth]) from [<bf01f01c>] (hci_event_pac
    ket+0xc2c/0x4aa4 [bluetooth])
    [<bf01e3f0>] (hci_event_packet+0x0/0x4aa4 [bluetooth]) from [<bf01a844>] (hci_rx_task+0x
    cc/0x27c [bluetooth])
    [<bf01a778>] (hci_rx_task+0x0/0x27c [bluetooth]) from [<c008eee4>] (tasklet_action+0xa0/
    0x15c)
    [<c008ee44>] (tasklet_action+0x0/0x15c) from [<c008f38c>] (__do_softirq+0x98/0x130)
     r7:00000101 r6:00000018 r5:00000001 r4:efc46000
    [<c008f2f4>] (__do_softirq+0x0/0x130) from [<c008f524>] (do_softirq+0x4c/0x58)
    [<c008f4d8>] (do_softirq+0x0/0x58) from [<c008f5e0>] (run_ksoftirqd+0xb0/0x1b4)
     r4:efc46000 r3:00000001
    [<c008f530>] (run_ksoftirqd+0x0/0x1b4) from [<c009f2a8>] (kthread+0x84/0x8c)
     r7:00000000 r6:c008f530 r5:efc47fc4 r4:efc41f08
    [<c009f224>] (kthread+0x0/0x8c) from [<c008cc84>] (do_exit+0x0/0x5f0)
    
    Signed-off-by: Ilia Kolomisnky <iliak@ti.com>
    Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  24. @larsclausen

    Bluetooth: Fix regression in L2CAP connection procedure

    Gustavo F. Padovan committed with larsclausen Jul 15, 2011
    Caused by the following commit, partially revert it.
    
    commit 9fa7e4f
    Author: Gustavo F. Padovan <padovan@profusion.mobi>
    Date:   Thu Jun 30 16:11:30 2011 -0300
    
        Bluetooth: Fix regression with incoming L2CAP connections
    
        PTS test A2DP/SRC/SRC_SET/TC_SRC_SET_BV_02_I revealed that
        ( probably after the df3c393 commit ) the l2cap connection
        could not be established in case when the "Auth Complete" HCI
        event does not arive before the initiator send "Configuration
        request", in which case l2cap replies with "Command rejected"
        since the channel is still in BT_CONNECT2 state.
    
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  25. @larsclausen

    gianfar: rx parser

    Sebastian Pöhn committed with larsclausen Jul 15, 2011
    Only let the rx parser be enabled if it is necessary (if VLAN extraction,
    IP or TCP checksumming or the rx queue filer are enabled). Otherwise
    disable it.
    
    The new routine gfar_check_rx_parser_mode should be run after every
    change on this features and will enable/disable the parser as necessary.
    
    Signed-off-by: Jiri Pirko <jpirko@redhat.com>
    Signed-off-by: Sebastian Poehn <sebastian.poehn@belden.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  26. @larsclausen

    r6040: only disable RX interrupt if napi_schedule_prep is successful

    Michael Thalmeier committed with larsclausen Jul 15, 2011
    When receiving the first RX interrupt before the internal call
    to napi_schedule_prep is successful the RX interrupt gets disabled
    and is never enabled again as the poll function never gets executed.
    
    Signed-off-by: Michael Thalmeier <Michael.Thalmeier@sigmatek.at>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  27. @larsclausen

    net: remove NETIF_F_ALL_TX_OFFLOADS

    Michał Mirosław committed with larsclausen Jul 13, 2011
    There is no software fallback implemented for SCTP or FCoE checksumming,
    and so it should not be passed on by software devices like bridge or bonding.
    
    For VLAN devices, this is different. First, the driver for underlying device
    should be prepared to get offloaded packets even when the feature is disabled
    (especially if it advertises it in vlan_features). Second, devices under
    VLANs do not get replaced without tearing down the VLAN first.
    
    This fixes a mess I accidentally introduced while converting bonding to
    ndo_fix_features.
    
    NETIF_F_SOFT_FEATURES are removed from BOND_VLAN_FEATURES because they
    are unused as of commit 712ae51.
    
    Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  28. @larsclausen

    net: sctp: fix checksum marking for outgoing packets

    Michał Mirosław committed with larsclausen Jul 13, 2011
    Packets to devices without NETIF_F_SCTP_CSUM (including NETIF_F_NO_CSUM)
    should be properly checksummed because the packets can be diverted or
    rerouted after construction. This still leaves packets diverted from
    NETIF_F_SCTP_CSUM-enabled devices with broken checksums. Fixing this
    needs implementing software offload fallback in networking core.
    
    For users of sctp_checksum_disable, skb->ip_summed should be left as
    CHECKSUM_NONE and not CHECKSUM_UNNECESSARY as per include/linux/skbuff.h.
    
    Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  29. @larsclausen

    watchdog: hpwdt depends on PCI

    Randy Dunlap committed with larsclausen Jul 16, 2011
    hpwdt is a PCI driver so it should depend on PCI.
    Fixes these build errors:
    
    drivers/watchdog/hpwdt.c:762: error: implicit declaration of function 'pci_iomap'
    drivers/watchdog/hpwdt.c:762: warning: assignment makes pointer from integer without a cast
    drivers/watchdog/hpwdt.c:797: error: implicit declaration of function 'pci_iounmap'
    
    Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
    Cc: Thomas Mingarelli <thomas.mingarelli@hp.com>
  30. @olafhering @larsclausen

    watchdog: fix hpwdt Kconfig regression in 3.0-rc

    olafhering committed with larsclausen Jul 15, 2011
    Remove Kconfig regression caused by commit
    a461615 "watchdog: hpwdt: build hpwdt as
    module by default with NMI_DECODING enabled"
    
    With the above change applied, hpwdt will be enabled unconditionally by just
    entering the Watchdog subscreen in menuconfig. Since this driver is not
    essential to boot any box it should remain disabled until it gets manually
    enabled, just like all other drivers.
    
    Signed-off-by: Olaf Hering <olaf@aepfle.de>
    Cc: Tony Camuso <tcamuso@redhat.com>
    Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  31. @larsclausen

    [media] tuner-core: fix a 2.6.39 regression with mt20xx

    Mauro Carvalho Chehab committed with larsclausen Jul 13, 2011
    As Simon reported, digital TV broke with mt20xx tuner due to
    commit ad020dc.
    
    The mt20xx tuner passes V4L2_TUNER_DIGITAL_TV to tuner core. However, the
    check_mode code now doesn't handle it well. Change the logic there to
    avoid the breakage, and fix a test for analog-only at g_tuner.
    
    Reported-by: Simon Arlott <simon@fire.lp0.eu>
    Tested-by: Simon Arlott <simon@fire.lp0.eu>
    Cc: stable@kernel.org
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  32. @dheitmueller @larsclausen

    [media] dvb_frontend: fix race condition in stopping/starting frontend

    dheitmueller committed with larsclausen Jul 4, 2011
    Attached is a patch which addresses a race condition in the DVB core
    related to closing/reopening the DVB frontend device in quick
    succession.  This is the reason that devices such as the HVR-1300,
    HVR-3000, and HVR-4000 have been failing to scan properly under MythTV
    and w_scan.
    
    The gory details of the race are described in the patch.
    
    Devin
    
    There is a race condition exhibited when channel scanners such as w_scan and
    MythTV quickly close and then reopen the frontend device node.
    
    Under normal conditions, the behavior is as follows:
    
    1.  Application closes the device node
    2.  DVB frontend ioctl calls dvb_frontend_release which sets
        fepriv->release_jiffies
    3.  DVB frontend thread *eventually* calls dvb_frontend_is_exiting() which
        compares fepriv->release_jiffies, and shuts down the thread if timeout has
        expired
    4.  Thread goes away
    5.  Application opens frontend device
    6.  DVB frontend ioctl() calls ts_bus_ctrl(1)
    7.  DVB frontend ioctl() creates new frontend thread, which calls
        dvb_frontend_init(), which has demod driver init() routine setup initial
        register state for demod chip.
    8.  Tuning request is issued.
    
    The race occurs when the application in step 5 performs the new open() call
    before the frontend thread is shutdown.  In this case the ts_bus_ctrl() call
    is made, which strobes the RESET pin on the demodulator, but the
    dvb_frontend_init() function never gets called because the frontend thread
    hasn't gone away yet.  As a result, the initial register config for the demod
    is *never* setup, causing subsequent tuning requests to fail.
    
    If there is time between the close and open (enough for the dvb frontend
    thread to be torn down), then in that case the new frontend thread is created
    and thus the dvb_frontend_init() function does get called.
    
    The fix is to set the flag which forces reinitialization if we did in fact
    call ts_bus_ctrl().
    
    This problem has been seen on the HVR-1300, HVR-3000, and HVR-4000, and is
    likely occuring on other designs as well where ts_bus_ctrl() actually strobes
    the reset pin on the demodulator.
    
    Note that this patch should supercede any patches submitted for the
    1300/3000/4000 which remove the code that removes GPIO code in
    cx8802_dvb_advise_acquire(), which have been circulating by users for some
    time now...
    
    Canonical tracking this issue in Launchpad 439163:
    
    Thanks to Jon Sayers from Hauppauge and Florent Audebert from Anevia S.A. for
    providing hardware to test/debug with.
    
    Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
    Cc: Jon Sayers <j.sayers@hauppauge.co.uk>
    Cc: Florent Audebert <florent.audebert@anevia.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  33. @larsclausen

    [media] media: fix radio-sf16fmr2 build when SND is not enabled

    Randy Dunlap committed with larsclausen Jun 30, 2011
    When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with:
    
    so make this driver depend on SND.
    
    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Cc: Hans Verkuil <hverkuil@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
    Cc: linux-media@vger.kernel.org
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  34. @ralfbaechle @larsclausen

    [media] MEDIA: Fix non-ISA_DMA_API link failure of sound code

    ralfbaechle committed with larsclausen Jun 24, 2011
    sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’:
    sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/es18xx.c: In function ‘snd_es18xx_playback_pointer’:
    sound/isa/es18xx.c:818:3: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[2]: *** [sound/isa/es18xx.o] Error 1
    sound/isa/sscape.c: In function ‘upload_dma_data’:
    sound/isa/sscape.c:481:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[2]: *** [sound/isa/sscape.o] Error 1
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_prepare’:
    sound/isa/ad1816a/ad1816a_lib.c:244:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_pointer’:
    sound/isa/ad1816a/ad1816a_lib.c:302:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_free’:
    sound/isa/ad1816a/ad1816a_lib.c:544:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/ad1816a/ad1816a_lib.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/ad1816a] Error 2
    sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_prepare’:
    sound/isa/es1688/es1688_lib.c:417:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_pointer’:
    sound/isa/es1688/es1688_lib.c:509:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/es1688/es1688_lib.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/es1688] Error 2
    sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_program’:
    sound/isa/gus/gus_dma.c:79:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_done’:
    sound/isa/gus/gus_dma.c:177:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/gus/gus_dma.o] Error 1
    sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_prepare’:
    sound/isa/gus/gus_pcm.c:591:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_pointer’:
    sound/isa/gus/gus_pcm.c:619:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/gus/gus_pcm.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/gus] Error 2
    sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’:
    sound/isa/sb/sb16_csp.c:228:227: error: case label does not reduce to an integer constant
    make[3]: *** [sound/isa/sb/sb16_csp.o] Error 1
    sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_prepare’:
    sound/isa/sb/sb16_main.c:276:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_pointer’:
    sound/isa/sb/sb16_main.c:456:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/sb/sb16_main.o] Error 1
    sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_prepare’:
    sound/isa/sb/sb8_main.c:172:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_pointer’:
    sound/isa/sb/sb8_main.c:425:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/sb/sb8_main.o] Error 1
    make[3]: Target `__build' not remade because of errors.
    make[2]: *** [sound/isa/sb] Error 2
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_prepare’:
    sound/isa/wss/wss_lib.c:1025:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_pointer’:
    sound/isa/wss/wss_lib.c:1160:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
    sound/isa/wss/wss_lib.c: In function ‘snd_wss_free’:
    sound/isa/wss/wss_lib.c:1695:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
    cc1: some warnings being treated as errors
    make[3]: *** [sound/isa/wss/wss_lib.o] Error 1
    warning: (RADIO_MIROPCM20) selects SND_ISA which has unmet direct dependencies (SOUND && !M68K && SND && ISA && ISA_DMA_API)
    
    A build with ISA && ISA_DMA && !ISA_DMA_API results in:
      CC      sound/isa/es18xx.o
      CC      sound/isa/sscape.o
      CC      sound/isa/ad1816a/ad1816a_lib.o
      CC      sound/isa/es1688/es1688_lib.o
      CC      sound/isa/gus/gus_dma.o
      CC      sound/isa/gus/gus_pcm.o
      CC      sound/isa/sb/sb16_csp.o
      CC      sound/isa/sb/sb16_main.o
      CC      sound/isa/sb/sb8_main.o
      CC      sound/isa/wss/wss_lib.o
    
    The root cause for this is hidden in this Kconfig warning:
    
    Adding a dependency on ISA_DMA_API to RADIO_MIROPCM20 fixes these issues.
    
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
    Acked-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  35. @jarodwilson @larsclausen

    [media] nuvoton-cir: make idle timeout more sane

    jarodwilson committed with larsclausen Jul 11, 2011
    The nuvoton-cir inherited an insanely low idle timeout value from the
    mceusb driver. We're fixing mceusb, should fix this driver too.
    
    Signed-off-by: Jarod Wilson <jarod@redhat.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Something went wrong with that request. Please try again.