New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize imports #176

Open
zuphilip opened this Issue Jan 23, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@zuphilip
Copy link
Collaborator

zuphilip commented Jan 23, 2017

From #154 (comment) by @QuLogic :

I've got a branch that removes pylab imports; should I open a PR for that?

You mean https://github.com/QuLogic/ocropy/commits/standard-import? Sure, open a PR with the pertinent commits, looks really helpful, I'll happily merge/cherry-pick.

Yes, that's the one; though I just noticed that it's based on the Python 3 work, so it'll be a pain to cherry-pick. Should get that in ASAP and then the rest would be easier.

Maybe it is also now easier to redo the work which was done in the PRs, because the forks may be too different now.

kba added a commit that referenced this issue Sep 29, 2017

Merge pull request #206 from zuphilip/imports
Standardize Imports I, #176

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 19, 2017

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 19, 2017

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017

Standardize imports for lineest.py, psegutils.py tmbdev#176
Both files are covered good by the current tests and
all tests are still fine with these changes.

This work is heavily based on the work by @QuLogic in the branch
https://github.com/QuLogic/ocropy/commits/standard-import

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017

Standardize imports for lineest.py, psegutils.py tmbdev#176
Both files are covered good by the current tests and
all tests are still fine with these changes.

This work is heavily based on the work by @QuLogic in the branch
https://github.com/QuLogic/ocropy/commits/standard-import

zuphilip added a commit to zuphilip/ocropy that referenced this issue Dec 27, 2017

zuphilip added a commit that referenced this issue Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment