New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in ocropus-gpageseg #251

Closed
jze opened this Issue Oct 16, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@jze
Contributor

jze commented Oct 16, 2017

The changes between rev 2e83dcb and 8d378ab caused a regression in ocropus-gpageseg. The older version produces a line like this:
good nrm

With the new version a line includes some pixels from the next line:
bad nrm

@stweil

This comment has been minimized.

Show comment
Hide comment
@stweil

stweil Oct 16, 2017

Contributor

Could you try to narrow it down to the commit which causes the regression by using git bisect?

Contributor

stweil commented Oct 16, 2017

Could you try to narrow it down to the commit which causes the regression by using git bisect?

@jze

This comment has been minimized.

Show comment
Hide comment
@jze

jze Oct 16, 2017

Contributor

2e83dcb and 8d378ab are consecutive commits for ocropus-gpageseg

Contributor

jze commented Oct 16, 2017

2e83dcb and 8d378ab are consecutive commits for ocropus-gpageseg

@stweil

This comment has been minimized.

Show comment
Hide comment
@stweil

stweil Oct 16, 2017

Contributor

Yes, but 8d378ab merged several commits. How can I reproduce the problem myself? Does a154e63 work?

Contributor

stweil commented Oct 16, 2017

Yes, but 8d378ab merged several commits. How can I reproduce the problem myself? Does a154e63 work?

@zuphilip zuphilip closed this in 20159d8 Oct 17, 2017

zuphilip added a commit that referenced this issue Oct 17, 2017

Merge pull request #252 from jze/gpageseg
Fix regression in ocropus-gpageseg #251
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Oct 17, 2017

Collaborator

Fixed in #252

Collaborator

zuphilip commented Oct 17, 2017

Fixed in #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment