RFC: Stream: add total #92
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code shouldn't be merged. However, posting it to get some comments. For a given use case, I needed to know the total number of items for a given paginated stream, without requesting all items in the stream (being very long). The ugly thing about the hack to this end in this PR is that you have to get the first element of the stream (by calling
Stream.next) beforeStream.totalbecomes available.Nicer solutions could be:
Stream.totalforce the streamStream.tso that the user has to provide a function that returns the total number of elements in the stream. When creating aStream.tfrom GitLab API requests, this function can do e.g. an HTTP HEAD on the API endpoint to get the total number.Any ideas?