Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation and build fixes. Now embedlite compiles on GCC4.8.3! #26

Merged
merged 2 commits into from Oct 8, 2014

Conversation

faenil
Copy link

@faenil faenil commented Oct 7, 2014

No description provided.

echo "ac_add_options --disable-strip" >> mozconfig
echo "ac_add_options --disable-mochitest" >> mozconfig
echo "ac_add_options --disable-installer" >> mozconfig
echo "ac_add_options --disable-javaxpcom" >> mozconfig
echo "ac_add_options --disable-crashreporter" >> mozconfig
echo "ac_add_options --disable-startupcache" >> mozconfig
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used those because they're the settings nemomobile uses (and they're the ones I tested the build with)...

if you think it's not needed I'll try deleting it and build again, no problem ;)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling startup cache help with debugging scripts et.c., but slowing down engine startups... I guess nemo has to double check that.

@tmeshkova
Copy link
Owner

Would you mind to merge/cherry-pick this fix to embedlite branch?

tmeshkova added a commit that referenced this pull request Oct 8, 2014
Compilation and build fixes. Now embedlite compiles on GCC4.8.3!
@tmeshkova tmeshkova merged commit 81fa5ce into tmeshkova:embedlite_33 Oct 8, 2014
@rojkov
Copy link
Collaborator

rojkov commented Oct 8, 2014

the embedlite-related commit has been cherry-picked to the embedlite branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants