Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater script not supported on Linux Mint #15

Closed
tdeeb opened this issue Nov 25, 2019 · 3 comments
Closed

Updater script not supported on Linux Mint #15

tdeeb opened this issue Nov 25, 2019 · 3 comments
Assignees
Labels

Comments

@tdeeb
Copy link

@tdeeb tdeeb commented Nov 25, 2019

Describe the bug
The updater script doesn't run on Linux Mint. It says the OS is unsupported.

To Reproduce

  1. Try to run the script on a Linux Mint machine.

Expected behavior
The updater should run on Linux Mint under the Debian/Ubuntu code path, as Mint is a derivative of Ubuntu.

Desktop (please complete the following information):

  • OS: Linux Mint

Additional context
"LinuxMint" is the DISTRIB_ID of Linux Mint in lsb-release, and it uses apt as the package manager.

All code paths looking for the distro will need to be updated to account for it (here, here, here, and here just to name a few).

@tmiland tmiland added the enhancement label Nov 25, 2019
@tmiland tmiland self-assigned this Nov 25, 2019
@tmiland

This comment has been minimized.

Copy link
Owner

@tmiland tmiland commented Nov 25, 2019

Hi,

Linux Mint has not been tested.

Please check out latest master and report back if everything works or not, and I'll push an update. 👍

Thanks.

@tdeeb

This comment has been minimized.

Copy link
Author

@tdeeb tdeeb commented Nov 25, 2019

Hi @tmiland, thanks for addressing this so quickly! I tested the script and managed to get a local Invidious instance running on my Mint installation! Thanks a lot!

@tdeeb tdeeb closed this Nov 25, 2019
@tmiland

This comment has been minimized.

Copy link
Owner

@tmiland tmiland commented Nov 25, 2019

Hi @tmiland, thanks for addressing this so quickly! I tested the script and managed to get a local Invidious instance running on my Mint installation! Thanks a lot!

That's great! Enjoy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.