Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: master
Commits on Oct 27, 2010
Commits on Oct 20, 2010
  1. @ry

    readme typo (thanks tmm1)

    ry authored
Commits on Oct 12, 2010
  1. @TooTallNate @ry

    Allow whitespace in the 'Content-Length' header.

    TooTallNate authored ry committed
Commits on Sep 12, 2010
  1. @ry

    avoid assertion failure in error case

    Cliff Frey authored ry committed
    Without this change, it is possible to get an assertion to fail by
    continuing to call http_parser_execute after it has returned an error.
    Specifically, the parser could be called with parser->state ==
    s_chunk_size_almost_done and parser->flags & F_CHUNKED set.  Then,
    F_CHUNKED could have been cleared, and an error could be hit.  In this
    case, the parser would have returned with F_CHUNKED clear, but
    parser->state == s_chunk_size_almost_done, resulting in an assertion
    failure on the next call.
    There are alternate solutions possible, including just saving all of
    the fields (state included) on error.
    I didn't add a test case because this is a bit annoying to test, but I
    can add one if necesssary.
Commits on Aug 27, 2010
  1. @bnoordhuis @ry

    Replace C++ style comments with C comments so it compiles with `gcc -…

    bnoordhuis authored ry committed
    …ansi -Wall`
Commits on Aug 18, 2010
  1. @ry

    save 8 bytes in http_parser structure

    Cliff Frey authored ry committed
    nread can never be larger than HTTP_MAX_HEADER_SIZE
  2. @ry

    Array type cleanups. Also save space

    Cliff Frey authored ry committed
    acceptable_header[x] is always assigned to a variable of type char, so
    the 'unsigned' is unnecessary.
    The other arrays can be of type int8_t/uint8_t to save space.
  3. @ry

    fixes for architectures with signed char default

    Cliff Frey authored ry committed
    This could have resulted in memory before the normal_url_char array
    being read on architectures with signed char default.
Commits on Jul 31, 2010
  1. @ry

    Changes to compile with clang

    ry authored
  2. @ry

    Use lookup tables of my own.

    ry authored
Commits on Jul 30, 2010
  1. @jterrace @ry

    Initialize method member to avoid falsely upgrading connections. Fixe…

    jterrace authored ry committed
    …d Issue #7
  2. @ry


    ry authored
  3. @ry

    Update size of struct in README

    ry authored
Commits on Jul 26, 2010
  1. @ry


    ry authored
  2. @ry

    Support long messages

    ry authored
Commits on Jul 24, 2010
  1. @ry

    Allow spaces in header fields

    ry authored
  2. @ry

    Fix long line

    ry authored
Commits on Jul 19, 2010
  1. @syngenio @ry

    redundant upgrade flag check

    syngenio authored ry committed
Commits on Jul 17, 2010
  1. @sgala @ry

    Upgrade on CONNECT method

    sgala authored ry committed
Commits on Jul 6, 2010
  1. @ry

    test: always try and break every testcase up into two submessages

    Cliff Frey authored ry committed
    This is just another way that would have caught the bug introduced in
    076fa15 and fixed by
  2. @ry

    fix http_parser_init to initialize flags correctly

    Cliff Frey authored ry committed
    Yay valgrind testing
    I don't believe that this actually mattered at all, because state was
    initialized correctly, and flags would be set to 0 almost immediately
  3. @ry

    test.c: get it to work with valgrind by using realloc less

    Cliff Frey authored ry committed
    For some reason valgrind would rapidly run out of memory on my machine
    without this.
  4. @ry

    Fix typo s_start_res_or_resp

    ry authored
  5. @ry

    Reset url_mark on s_req_host

    ry authored
    add a new scan test. Report and fix by Master Becker.
Commits on Jun 28, 2010
  1. @ewencp @ry

    Add definitions and typedefs to support compilation in Visual Studio …

    ewencp authored ry committed
    …under C++ mode.
Commits on Jun 24, 2010
  1. @ry
  2. @ry

    Add subversion request methods

    ry authored
Commits on Jun 12, 2010
  1. @ry

    do not access random memory before lowcase array

    Cliff Frey authored ry committed
    This matters because char is signed by default on x86, so bytes with
    values above 127 could have theoretically survived a pass through
    lowcase (assuming that there was some non-zero data before the lowcase
Commits on Jun 11, 2010
  1. @ry

    save more space by removing buffer and shortening method

    Cliff Frey authored ry committed
    This also fixes test failures from the previous commit.
    It also adds support for the LOCK method, which was previously
    This brings the size of http_parser from 44 bytes to 32 bytes.  It
    also makes the code substantially shorter, at a slight cost in
  2. @ry

    add tests of method strings

    Cliff Frey authored ry committed
    Currently this test fails, because short method strings do not cause
    failures, even if they are unknown methods.  However, long unknown
    method strings do cause errors.
  3. @ry

    test: fix compile warnings about printf + size_t

    Cliff Frey authored ry committed
  4. @ry

    remove body_read

    Cliff Frey authored ry committed
    This saves space in the structure (it is now 28 bytes on x86), and
    makes the handling of content_length more consistent between chunked
    encoding and non-chunked-encoding.
  5. @ry

    only increment nread while looking at headers

    Cliff Frey authored ry committed
    This fixes a possible issue where a very large body (one that involves
    > 80*1024 calls to http_parser_execute) will cause the next request
    with that parser to return an error because it believes that this is
    an overflow condition.
  6. @ry

    test.c: add cases for header overflow conditions

    Cliff Frey authored ry committed
    This currently fails, but the next commit fixes the issue.
Commits on Jun 6, 2010
  1. @ry

    Support request URLs without schema

    ry authored
    Test case from Poul T Lomholt <>
Something went wrong with that request. Please try again.