Permalink
Browse files

Added FIXMEs to fix bad IR

  • Loading branch information...
1 parent 96cec9a commit d24b9313145a0628e331fe97a23c998aa040af7a @subbuss subbuss committed Apr 5, 2011
View
1 src/org/jruby/compiler/ir/IRScopeImpl.java
@@ -52,6 +52,7 @@
* and so on ...
*/
public abstract class IRScopeImpl implements IRScope {
+ // SSS FIXME: Dumb design leaking a live operand into a non-operand!!
Operand container; // Parent container for this context
RubyModule containerModule; // Live version of container
IRScope lexicalParent; // Lexical parent scope
View
1 src/org/jruby/compiler/ir/instructions/DefineClassMethodInstr.java
@@ -38,6 +38,7 @@ public void simplifyOperands(Map<Operand, Operand> valueMap) {
super.simplifyOperands(valueMap);
Operand o = container;
Operand v = valueMap.get(o);
+ // SSS FIXME: Dumb design leaking operand into IRScopeImpl -- hence this setting going on here. Fix it!
if (v != null)
// ENEBO: Set container also?
method.setContainer(v);
View
1 src/org/jruby/compiler/ir/instructions/DefineInstanceMethodInstr.java
@@ -38,6 +38,7 @@ public void simplifyOperands(Map<Operand, Operand> valueMap) {
super.simplifyOperands(valueMap);
Operand o = method.getContainer();
Operand v = valueMap.get(o);
+ // SSS FIXME: Dumb design leaking operand into IRScopeImpl -- hence this setting going on here. Fix it!
if (v != null)
method.setContainer(v);
}

0 comments on commit d24b931

Please sign in to comment.