Supprt for Windows #55

Merged
merged 1 commit into from Dec 29, 2012

Conversation

Projects
None yet
3 participants
@nitoyon
Contributor

nitoyon commented Dec 23, 2012

pygments.rb 0.3.3 doesn't work in Windows.

popen.rb

  • /dev/null -> NUL:
  • popen('mentos.py') -> popen('python mentos.py')

mentos.py

  • resource module and signal.SIGHUP are not supported
  • force LF
Supprt for Windows
popen.rb
* `/dev/null` -> `NUL:`
* `popen('mentos.py')` -> `popen('python mentos.py')`

mentos.py
* `resource` module and `signal.SIGHUP` are not supported
* force LF
@Eric-Guo

This comment has been minimized.

Show comment Hide comment
@Eric-Guo

Eric-Guo Dec 26, 2012

@nitoyon thanks your great job, testing this pull request on the my Octopress blog and it works perfect! hoping @tmm1 can merge those change to master soon.

@nitoyon thanks your great job, testing this pull request on the my Octopress blog and it works perfect! hoping @tmm1 can merge those change to master soon.

@tnm

This comment has been minimized.

Show comment Hide comment
@tnm

tnm Dec 29, 2012

Collaborator

This seems quite reasonable and I'm pleasantly surprised Windows support was so easy :) Merging. Will cut a new pygments.rb gem release soon after.

Collaborator

tnm commented Dec 29, 2012

This seems quite reasonable and I'm pleasantly surprised Windows support was so easy :) Merging. Will cut a new pygments.rb gem release soon after.

tnm added a commit that referenced this pull request Dec 29, 2012

@tnm tnm merged commit b414b5d into tmm1:master Dec 29, 2012

@tnm

This comment has been minimized.

Show comment Hide comment
@tnm

tnm Dec 29, 2012

Collaborator

0.3.4 pushed to rubygems, thanks much @nitoyon

Collaborator

tnm commented Dec 29, 2012

0.3.4 pushed to rubygems, thanks much @nitoyon

@nitoyon

This comment has been minimized.

Show comment Hide comment
@nitoyon

nitoyon Dec 29, 2012

Contributor

Thanks too😄

Contributor

nitoyon commented Dec 29, 2012

Thanks too😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment