Support windows #90

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
8 participants
@koron

koron commented Sep 2, 2013

I wrote these patches to support MS Windows.
After these patch, we can pass all tests by rake test on Windows.


Windows doesn't support which command.
And python 2.x binaries officially distributed for Windows don't include python2.exe.

@koron koron referenced this pull request in jekyll/jekyll Sep 2, 2013

Closed

Collect docs for Windows #1387

@nitoyon

This comment has been minimized.

Show comment
Hide comment
@nitoyon

nitoyon Nov 12, 2013

Contributor

👍

Contributor

nitoyon commented Nov 12, 2013

👍

@comuttun

This comment has been minimized.

Show comment
Hide comment
@comuttun

comuttun Jan 31, 2014

@tmm1 Why is this not merged yet?
I've met this bug at Windows and the problem is fixed if I merge refs#90/head locally.
current master with this is still all tests green.

@tmm1 Why is this not merged yet?
I've met this bug at Windows and the problem is fixed if I merge refs#90/head locally.
current master with this is still all tests green.

@koistya

This comment has been minimized.

Show comment
Hide comment
@koistya

koistya Jun 30, 2014

I'm having this issue with Jekyll which many guys on forums relate to pygments.rb:

/posix-spawn-0.3.8/lib/posix/spawn.rb:162
warning: cannot close fd before spawn

Using pygments.rb v0.6.0

koistya commented Jun 30, 2014

I'm having this issue with Jekyll which many guys on forums relate to pygments.rb:

/posix-spawn-0.3.8/lib/posix/spawn.rb:162
warning: cannot close fd before spawn

Using pygments.rb v0.6.0

@garfieldnate

This comment has been minimized.

Show comment
Hide comment
@garfieldnate

garfieldnate Jul 6, 2014

Just a note that this is still an important issue for Jekyll and Octopress users.

Just a note that this is still an important issue for Jekyll and Octopress users.

@hickford

This comment has been minimized.

Show comment
Hide comment
@hickford

hickford Oct 4, 2014

Contributor

Please merge! f03df35 broke pygments.rb—and all the software that depends on it—on Windows. That's upset several thousand Jekyll bloggers https://stackoverflow.com/questions/17364028/jekyll-on-windows-pygments-not-working

Contributor

hickford commented Oct 4, 2014

Please merge! f03df35 broke pygments.rb—and all the software that depends on it—on Windows. That's upset several thousand Jekyll bloggers https://stackoverflow.com/questions/17364028/jekyll-on-windows-pygments-not-working

@avdv

This comment has been minimized.

Show comment
Hide comment
@avdv

avdv Oct 7, 2014

👍

Um, thinking about this again... Since you could install Python 2 and 3 side by side on Windows it would be no good idea to just blindly call the "python" binary. On Windows you could use the Python Launcher called as "py -2" which will spawn a Python 2 interpreter for you.

avdv commented Oct 7, 2014

👍

Um, thinking about this again... Since you could install Python 2 and 3 side by side on Windows it would be no good idea to just blindly call the "python" binary. On Windows you could use the Python Launcher called as "py -2" which will spawn a Python 2 interpreter for you.

@koron

This comment has been minimized.

Show comment
Hide comment
@koron

koron Oct 7, 2014

Windows doesn't support which command as default.
And python 2.x binaries officially distributed for Windows don't include python2.exe.

koron commented Oct 7, 2014

Windows doesn't support which command as default.
And python 2.x binaries officially distributed for Windows don't include python2.exe.

@avdv

This comment has been minimized.

Show comment
Hide comment
@avdv

avdv Oct 7, 2014

Windows doesn't support which command as default.

Exactly.

And python 2.x binaries officially distributed for Windows don't include python2.exe.

True. But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

That's why I suggest to use the Python Launcher instead (which gets installed in %systemroot% and thus will always be found - regardless of the directories in %PATH%). The launcher will then figure out how to start a suitable Python interpreter by itself.

avdv commented Oct 7, 2014

Windows doesn't support which command as default.

Exactly.

And python 2.x binaries officially distributed for Windows don't include python2.exe.

True. But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

That's why I suggest to use the Python Launcher instead (which gets installed in %systemroot% and thus will always be found - regardless of the directories in %PATH%). The launcher will then figure out how to start a suitable Python interpreter by itself.

@koron

This comment has been minimized.

Show comment
Hide comment
@koron

koron Oct 7, 2014

But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

Incomplete is better than nothing.

koron commented Oct 7, 2014

But just calling "python" gets you the "default" Python interpreter which might be Python 3, and that will fail.

Incomplete is better than nothing.

@avdv

This comment has been minimized.

Show comment
Hide comment
@avdv

avdv Oct 9, 2014

Incomplete is better than nothing.

I disagree on that one. There's no point in fixing something, rolling out a release if you know in advance that it will not work (especially when you have a better solution).

Would you mind updating your pull request to use "py -2" please? Thanks!

avdv commented Oct 9, 2014

Incomplete is better than nothing.

I disagree on that one. There's no point in fixing something, rolling out a release if you know in advance that it will not work (especially when you have a better solution).

Would you mind updating your pull request to use "py -2" please? Thanks!

@hickford

This comment has been minimized.

Show comment
Hide comment
@hickford

hickford Oct 10, 2014

Contributor

@avdv If it helps, I've done that at #138 . I don't mind whom you pull, but let's fix Windows somehow.

Contributor

hickford commented Oct 10, 2014

@avdv If it helps, I've done that at #138 . I don't mind whom you pull, but let's fix Windows somehow.

@tmm1

This comment has been minimized.

Show comment
Hide comment
@tmm1

tmm1 Mar 24, 2015

Owner

This was fixed in #138

Owner

tmm1 commented Mar 24, 2015

This was fixed in #138

@tmm1 tmm1 closed this Mar 24, 2015

@koron koron deleted the koron:support-windows branch Mar 24, 2015

@koron

This comment has been minimized.

Show comment
Hide comment

koron commented Mar 24, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment