Gracefully handle unreadable directories#86
Merged
mislav merged 3 commits intotmm1:masterfrom Aug 22, 2018
Merged
Conversation
mislav
requested changes
Aug 20, 2018
Collaborator
mislav
left a comment
There was a problem hiding this comment.
Nice catch! Thank you for handling this.
lib/ripper-tags/data_reader.rb
Outdated
| end | ||
|
|
||
| def resolve_files_in_directory(directory, depth, &block) | ||
| unless File.readable?(directory) |
Collaborator
There was a problem hiding this comment.
Instead of checking File.readable? could we handle an exception from Dir.entries?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review - sure, I've pushed a fixup to do that
The `rescue Errno::EACCES` clause now only applies to `Dir.entries()` call and not to the yielded block.
209f8f7 to
131dbcf
Compare
mislav
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an unreadable directory considered by
ripper-tags, an exception is raised:(tested with 0.6.0)
This PR gracefully handles such directories, by skipping them (and logging if
--verboseis given).To reproduce the existing behaviour, run:
with this PR, we now have