Gracefully handle unreadable directories #86
Merged
Conversation
Nice catch! Thank you for handling this. |
lib/ripper-tags/data_reader.rb
Outdated
@@ -75,6 +71,21 @@ def resolve_file(file, depth = 0, &block) | |||
end | |||
end | |||
|
|||
def resolve_files_in_directory(directory, depth, &block) | |||
unless File.readable?(directory) |
mislav
Aug 20, 2018
Collaborator
Instead of checking File.readable?
could we handle an exception from Dir.entries
?
Instead of checking File.readable?
could we handle an exception from Dir.entries
?
owst
Aug 21, 2018
Author
Contributor
Thanks for the review - sure, I've pushed a fixup to do that
Thanks for the review - sure, I've pushed a fixup to do that
The `rescue Errno::EACCES` clause now only applies to `Dir.entries()` call and not to the yielded block.
209f8f7
to
131dbcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If there is an unreadable directory considered by
ripper-tags
, an exception is raised:(tested with 0.6.0)
This PR gracefully handles such directories, by skipping them (and logging if
--verbose
is given).To reproduce the existing behaviour, run:
with this PR, we now have