This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Improvements to foreign codegen #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SquidDev
commented
Nov 25, 2018
•
SquidDev
commented
- Emit foreign literals inline, rather than adding a new upvalue.
- Inline trivial foreign functions. For now this'll be those which refer to each variable exactly once, in order they are passed, though this could be extended in the future.
- Use the postprocessor system for emitting foreign expressions on demand, rather than unconditionally.
Previously we would only skip other variables. We extend this to skip any trivial expression, which means we don't end up emitting quite so many absurd temporaries.
We now store any "pending" builtins within the TopEmitState, and emit them once the main body has been emitted, using the Postprocess pass.
SquidDev
changed the title
|
|
plt-amy
pushed a commit
that referenced
this pull request
Jan 12, 2020
* Prepare for some basic inlining of foreign declarations * Allow variable binds to skip trivial expressions too. Previously we would only skip other variables. We extend this to skip any trivial expression, which means we don't end up emitting quite so many absurd temporaries. * Rewrite the system for generating builtins We now store any "pending" builtins within the TopEmitState, and emit them once the main body has been emitted, using the Postprocess pass. * Run foreign values and constructors through the new builtin system * Hlinty hlints * Add a primitive inliner for Lua statements * Allow inlining statements too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.