New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut injection throwing errors #2

Closed
neocotic opened this Issue Apr 20, 2011 · 1 comment

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Apr 20, 2011

It seems that sometimes the errors are being thrown when injecting the shortcuts.js script in to open tabs caused by undeclared permissions in the manifest. So far I believe this only happens for special pages (e.g. chrome_://_) as these permissions cannot be requested for these but could potentially be for others.

A possible solution involves wrapping each injection with a try/catch block and/or checking for special pages.

@ghost ghost assigned neocotic Apr 20, 2011

@neocotic neocotic closed this in fe2941e Jun 3, 2011

@neocotic neocotic reopened this Jun 3, 2011

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jul 19, 2011

Member

This has been fixed to an extent but chrome will throw errors when attempting to inject these scripts as protected pages load. However, these errors should have no damaging effect to the extension.

Member

neocotic commented Jul 19, 2011

This has been fixed to an extent but chrome will throw errors when attempting to inject these scripts as protected pages load. However, these errors should have no damaging effect to the extension.

@neocotic neocotic closed this Jul 19, 2011

neocotic added a commit that referenced this issue May 20, 2013

@neocotic neocotic removed the Error label Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment