New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign options page #47

Closed
neocotic opened this Issue Nov 7, 2011 · 7 comments

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Nov 7, 2011

As the title suggests... The new look should coexist with the style and layout of Chrome's internal option pages (chrome://settings). Help sections being triggered by "Learn more" links and tabs controlled by the left navigation. No search box should exist.

Resources could possibly be looked up the same way as the internal option pages (e.g. chrome://resources/css/button.css). I'm only guessing this but it would be really useful if it could.

Finally, it might be useful if a better framework could be in use for i18n replacement. Chrome's internal pages use the attribute i18n-content to contain the name of the message to be looked up used to replace the element's content. However, consideration should be given to how attributes and messages with arguments should be handled, but this a good start.

All screenshots showing the options page should be updated afterwards.

@ghost ghost assigned neocotic Nov 7, 2011

@neocotic neocotic referenced this issue Nov 8, 2011

Closed

Restructure data #49

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jan 5, 2012

Member

See comments on iOrder for notes on how this was implemented there.

Member

neocotic commented Jan 5, 2012

See comments on iOrder for notes on how this was implemented there.

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jan 13, 2012

Member

Also see the new comment on iOrder for information of how it was finally implemented.

Member

neocotic commented Jan 13, 2012

Also see the new comment on iOrder for information of how it was finally implemented.

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jan 16, 2012

Member

Seems to be working fine. Currently I'm not planning on redesigning the options page but perhaps in the future if Chrome adds some kind of new framework and/or L&F for this.

Therefore this only includes the simplification of i18n within the options page and all other areas of the extension along with some other minor tweaks.

Member

neocotic commented Jan 16, 2012

Seems to be working fine. Currently I'm not planning on redesigning the options page but perhaps in the future if Chrome adds some kind of new framework and/or L&F for this.

Therefore this only includes the simplification of i18n within the options page and all other areas of the extension along with some other minor tweaks.

@neocotic neocotic closed this Jan 16, 2012

@neocotic neocotic reopened this Jan 16, 2012

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jan 16, 2012

Member

There's currently a cosmetic issue with facebox and the templates guide where the close button is outside of the boundaries. I thought I previously fixed this but it seems that fix now breaks the close button when the guide is displayed. It's something to do with the display type but I think the following workaround will fix this;

facebox = $ '#facebox > .popup > .content'
$(document).bind 'reveal.facebox', ->
  margin  = if facebox.find('> .template').length then '0' else ''
  facebox.css 'margin-right', margin
Member

neocotic commented Jan 16, 2012

There's currently a cosmetic issue with facebox and the templates guide where the close button is outside of the boundaries. I thought I previously fixed this but it seems that fix now breaks the close button when the guide is displayed. It's something to do with the display type but I think the following workaround will fix this;

facebox = $ '#facebox > .popup > .content'
$(document).bind 'reveal.facebox', ->
  margin  = if facebox.find('> .template').length then '0' else ''
  facebox.css 'margin-right', margin
@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Jan 16, 2012

Member

Now works fine.

Member

neocotic commented Jan 16, 2012

Now works fine.

@neocotic neocotic closed this Jan 16, 2012

neocotic added a commit that referenced this issue Jan 24, 2012

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 2, 2012

Member

Now looking at Twitter's bootstrap framework for redesigning the page.

Member

neocotic commented Feb 2, 2012

Now looking at Twitter's bootstrap framework for redesigning the page.

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 6, 2012

Member

Completely redesigned the options page and I'm extremely happy with the results. I'm now considering this closed but expect there may be minor changes to this page still before full release that relate to outstanding issues.

Member

neocotic commented Feb 6, 2012

Completely redesigned the options page and I'm extremely happy with the results. I'm now considering this closed but expect there may be minor changes to this page still before full release that relate to outstanding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment