New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically save options #60

Closed
neocotic opened this Issue Jan 30, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Jan 30, 2012

Remove the need for the user to click the "Save & Close" button on the options page.

Basically, bind events to automatically persist the corresponding option whenever it is changed. I'm not sure how this will work for changing templates yet but, should performance be an issues, update and/or persist these asynchronously. However, care should be taken for how validation is now performed as some validation was only carried out when the "Save & Close" button was clicked. These will now need to be bound to the relevant fields, and only when they are being changed by the user and not by a change to the list selection.

@neocotic

This comment has been minimized.

Member

neocotic commented Jan 30, 2012

I'm happy with these changes but I want to test this more in the Templates section as this is the most complex.

neocotic added a commit that referenced this issue Feb 3, 2012

neocotic added a commit that referenced this issue Feb 4, 2012

@neocotic

This comment has been minimized.

Member

neocotic commented Feb 6, 2012

I'm really happy with this and can't find any more problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment