New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Tags #63

Closed
neocotic opened this Issue Feb 6, 2012 · 5 comments

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Feb 6, 2012

A few more tag implementations to consider;

  • Resolution: Complex tag (map) with width and height properties
    • Use window.screen to derive values
  • Depth: Simple tag
    • Use window.screen to derive value

@ghost ghost assigned neocotic Feb 6, 2012

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 6, 2012

Member

Another idea;

  • Dimension: Complex tag (map) with width and height properties
    • Use the following logic to derive the values within the content script;
dimensions =
  height: window.innerHeight
  width:  window.innerWidth
Member

neocotic commented Feb 6, 2012

Another idea;

  • Dimension: Complex tag (map) with width and height properties
    • Use the following logic to derive the values within the content script;
dimensions =
  height: window.innerHeight
  width:  window.innerWidth
@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 6, 2012

Member

Splitting both resolution and dimension tags up (e.g. screenWidth, pageHeight).

Member

neocotic commented Feb 6, 2012

Splitting both resolution and dimension tags up (e.g. screenWidth, pageHeight).

neocotic added a commit that referenced this issue Feb 6, 2012

neocotic added a commit that referenced this issue Feb 7, 2012

@neocotic neocotic closed this Feb 7, 2012

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 7, 2012

Member

I also want to add a new complex type (map) template which enables access to the properties of the executed template as well as another (array) plugins which contains all plugin names (see window.navigator.plugins - sorted and unique).

Member

neocotic commented Feb 7, 2012

I also want to add a new complex type (map) template which enables access to the properties of the executed template as well as another (array) plugins which contains all plugin names (see window.navigator.plugins - sorted and unique).

@neocotic neocotic reopened this Feb 7, 2012

neocotic added a commit that referenced this issue Feb 7, 2012

@neocotic neocotic closed this Feb 7, 2012

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 8, 2012

Member

Again, I want to add more tags and I don't see the point in raising another issue. All of these will need to be extracted using content.coffee as they are derived from the document;

  • characterSet (simple tag) - document.characterSet
  • lastModified (simple tag and function) - document.lastModified - Function accepts an optional format string - Use Date.parse
  • links (complex tag - array) - document.links[n]?.href
  • referrer (simple tag) - document.referrer
  • scripts (complex tag - array) - document.scripts[n]?.src
  • styleSheets (complex tag - array) - document.styleSheets[n]?.href

I'd also like to note that selectionLinks has been deprecated and renamed to selectedLinks as part of this change.

Member

neocotic commented Feb 8, 2012

Again, I want to add more tags and I don't see the point in raising another issue. All of these will need to be extracted using content.coffee as they are derived from the document;

  • characterSet (simple tag) - document.characterSet
  • lastModified (simple tag and function) - document.lastModified - Function accepts an optional format string - Use Date.parse
  • links (complex tag - array) - document.links[n]?.href
  • referrer (simple tag) - document.referrer
  • scripts (complex tag - array) - document.scripts[n]?.src
  • styleSheets (complex tag - array) - document.styleSheets[n]?.href

I'd also like to note that selectionLinks has been deprecated and renamed to selectedLinks as part of this change.

@neocotic

This comment has been minimized.

Show comment
Hide comment
@neocotic

neocotic Feb 9, 2012

Member

I would like to add three more tags based on meta elements. Again, these will need to be extacted using content.coffee as they are derived from the DOM.

  • author (simple tag) - document.querySelector('meta[name="author"]')?.content
  • description (simple tag) - document.querySelector('meta[name="description"]')?.content
  • keywords (complex tag - array) - document.querySelector('meta[name="keywords"]')?.content - Split on ,, trimmed and then empties removed

All of which should be trimmed if they exist.

Member

neocotic commented Feb 9, 2012

I would like to add three more tags based on meta elements. Again, these will need to be extacted using content.coffee as they are derived from the DOM.

  • author (simple tag) - document.querySelector('meta[name="author"]')?.content
  • description (simple tag) - document.querySelector('meta[name="description"]')?.content
  • keywords (complex tag - array) - document.querySelector('meta[name="keywords"]')?.content - Split on ,, trimmed and then empties removed

All of which should be trimmed if they exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment