New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content script broken #77

Closed
neocotic opened this Issue Mar 6, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Mar 6, 2012

While investigating #76 I noticed that CoffeeScript is incorrectly compiling the content script.

      description:   getMeta 'description'
      keywords:      getMeta 'keywords', yes
      lastModified:  document.lastModified

Is being compiled as...

      keywords: getMeta('keywords')
    }, true, {
      lastModified: document.lastModified,

This is resulting in most of the derived values from being discarded. Fortunately, the fix is simply to wrap the arguments in parenthesis.

@neocotic

This comment has been minimized.

Member

neocotic commented Mar 6, 2012

I'm happy with this fix, closing off.

@neocotic neocotic closed this Mar 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment