New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save exports #92

Closed
neocotic opened this Issue Mar 16, 2012 · 3 comments

Comments

Projects
None yet
1 participant
@neocotic
Member

neocotic commented Mar 16, 2012

I'm not sure when or why this has happened but it seems that the "Save As..." button on the Export dialog has stopped working. It was definitely working in 1.0.0 so I'll have to look in to this.

@ghost ghost assigned neocotic Mar 16, 2012

@neocotic

This comment has been minimized.

Member

neocotic commented Mar 16, 2012

The error causing this problem is thrown by window.webkitRequestFileSystem, which I'm currently not capturing errors for on options.coffee:429. When I add an additional callback function to the arguments passed to this method I noticed FileError.SECURITY_ERR is being thrown.

I'll need to add this extra error handler to the code (maybe in a few more places) to ensure that errors are being captured. However, my main concern is why this is happening. I'll try to test this later tonight on my Mac but if anyone else could has time could they please let me know if the "Save As..." button works for them.

I'm wondering if the web security at my work is now blocking this functionality as they seem to have just started blocking logging in to Google accounts as well.

@neocotic

This comment has been minimized.

Member

neocotic commented Mar 16, 2012

I've tested this at home and it worked fine so I'm guessing this is only a problem behind strict web security. However, I'll still add the error handler to provide feedback to users in this scenario.

@neocotic

This comment has been minimized.

Member

neocotic commented Apr 20, 2012

I've improved the error handling and I'm quite happy with it now. Will do some more testing and maybe add more i18n error messages, perhaps read/write-specific.

@neocotic neocotic closed this Apr 20, 2012

@neocotic neocotic removed the Error label Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment