Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Twitter Bootstrap #111

Closed
neocotic opened this issue Aug 1, 2012 · 3 comments · Fixed by #124
Closed

Update Twitter Bootstrap #111

neocotic opened this issue Aug 1, 2012 · 3 comments · Fixed by #124
Assignees
@neocotic
Labels
enhancement
Milestone
1.2.0

Comments

@neocotic
Copy link
Member

neocotic commented Aug 1, 2012

Update Twitter Bootstrap to the latest version to incorporate its bug fixes etc.

Check the changelog and ensure no additional changes need to be made for compatibility.
@ghost ghost assigned neocotic Aug 1, 2012
@neocotic neocotic mentioned this issue Jan 4, 2013
Merged
@neocotic
Copy link
Member Author

neocotic commented Jan 7, 2013

Bootstrap has been updated as part of #120 so this can now be closed. I did a side-by-side comparison of the popup and options page and noticed no differences.

@neocotic neocotic closed this as completed Jan 7, 2013
@neocotic
Copy link
Member Author

neocotic commented Jan 7, 2013

Turns out I tested it against the wrong branch(doh!) and there are definitely some changes required to be compatible.

@neocotic neocotic reopened this Jan 7, 2013
@neocotic neocotic mentioned this issue Jan 7, 2013
Merged
@neocotic
Copy link
Member Author

neocotic commented Jan 7, 2013

Fixes/patches have been delivered in #125 after a bit of a mess.

@neocotic neocotic closed this as completed Jan 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocotic neocotic

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Library support tmplat-extension/tmplat
1 participant
@neocotic