Generalize Anchor Tags options #187
Closed
Comments
neocotic
added a commit
that referenced
this issue
May 13, 2013
…and its corresponding options more general for links
Merged
Backup/restore developer functionality on |
Backup/restore will be fixed as part of #190 for convenience sake. Also, executing the following on the background page of older versions works as a good polyfiller: (function () {
var __store__ = window.__store__ = {};
__store__.backup = function () {
var obj = {}, prop;
for (prop in localStorage) {
if (localStorage.hasOwnProperty(prop)) {
obj[prop] = JSON.parse(localStorage[prop]);
}
}
return encodeURIComponent(JSON.stringify(obj));
};
__store__.clear = function () {
localStorage.clear();
};
__store__.restore = function (str) {
var obj, prop;
obj = JSON.parse(decodeURIComponent(str));
for (prop in obj) {
if (obj.hasOwnProperty(prop)) {
localStorage[prop] = JSON.stringify(obj[prop]);
}
}
};
}()); Unfortunately, the JS console can sometimes truncate strings with ext.copy(__store__.backup(), true); |
These changes have been implemented as part of PR #190. Additionally, the backup/restore developer functionality in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to make the "Anchor Tags" section of the options page more general and applicable to links.
anchorTarget
should be something likelinkNew
to show that templates should be instructed to render links that open in new tabs/windows where possible.anchorTitle
should be something likelinkTitle
to show that templates should be instructed to render links with a corresponding title where possible.Emphasis on the "where possible" as this can be implemented by predefined and custom templates to generate any kind of markup link (HTML, Wiki, Markdown etc.), some of which don't support the functionality.
Backwards compatibility is obviously vital here and predefined templates should be updated to reflect this, again, where possible.
The text was updated successfully, but these errors were encountered: