Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goo.gl 403 error #20

Closed
neocotic opened this issue Jul 27, 2011 · 6 comments
Closed

goo.gl 403 error #20

neocotic opened this issue Jul 27, 2011 · 6 comments
Assignees
Milestone

Comments

@neocotic
Copy link
Member

There seems to be an issue with authentication for the goo.gl URL shortener. I believe it might be having problems when the same version is authenticated with multiple machines.

@ghost ghost assigned neocotic Jul 27, 2011
@neocotic
Copy link
Member Author

I've experimented and this doesn't seem to be related with multiple installations and will need to retest on my Mac as that's the only place I got the error. May need to debug the exact response.

@neocotic
Copy link
Member Author

neocotic commented Aug 8, 2011

I found that this problem was with authentication tokens stored in localStorage on my Mac. I believe I revoked access for this from my Google dashboard but I would have thought that this would have resulted in a new authentication process next time I attempted to contact goo.gl. I may need to experiment with this further and may require an option to clear any stored values from localStorage (e.g. Flush Tokens button).

@neocotic
Copy link
Member Author

Hopefully this should resolve any future problems.

@neocotic neocotic reopened this Feb 10, 2012
@neocotic
Copy link
Member Author

I want to look at this again to make this slightly cleaner. Instead of directly deleting the values stored in localStorage or checking their existence I could probably use oauth.clearTokens() and oauth.hasToken() respectively. I'll investigate this further. 1.0.0 must be perfect!

@neocotic
Copy link
Member Author

Also, I'm tempted to change the way that this is worded etc.

Instead of having a flush button when the user is authenticated. Add a Login button to the options page that, when clicked, calls oauth.authorize and then changes to a Logout button if it was a success which, when clicked again, will cause the tokens to be cleared and change back to the Login button. This would make callUrlShortener much simpler and the whole process cleaner. Finally, this would mean that OAuth enabled detection would no longer be required and it's just a matter of whether or not we have the tokens. Obviously, the user will be logged out by default (for new installations).

The googlOAuth option could also be deprecated (and maybe replaced with googlAccount) and change its functionality to oauth.hasToken().

neocotic added a commit that referenced this issue Feb 13, 2012
neocotic added a commit that referenced this issue Feb 13, 2012
neocotic added a commit that referenced this issue Feb 13, 2012
@neocotic
Copy link
Member Author

This feels much more natural now and works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant