Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More supported extensions #21

Closed
neocotic opened this issue Jul 28, 2011 · 3 comments
Closed

More supported extensions #21

neocotic opened this issue Jul 28, 2011 · 3 comments

Comments

@neocotic
Copy link
Member

@neocotic neocotic commented Jul 28, 2011

I think more extensions should be supported when extracting information on the current page. The following is a list of extensions that will be added and an example of their raw URL and titles when copied without support;

IE Tab Classic

IE Tab Multi (Enhance)

  • Title: View source - Wikipedia, the free encyclopedia
  • URL: chrome-extension://fnfnbeppfinmnjnjhedifcfllpcfgeea/navigate.html?chromeurl=[escape]http%3A//en.wikipedia.org/w/index.php%3Ftitle%3DMain_Page%26action%3Dedit

Mozilla Gecko Tab

The above examples were based on this information;

It will be best if the supported extensions mechanism is redesigned to easily support multiple extensions.

@ghost ghost assigned neocotic Jul 28, 2011
@neocotic
Copy link
Member Author

@neocotic neocotic commented Jul 28, 2011

During testing I've discovered that the current IE Tab support is broken and attempting to use URL Copy on a page when IE Tab is active will result in an error.

The problem appears to be with the extracted URL no longer being decoded. The fix is simply ensuring decodeURIComponent is called with the extracted URL before being returned. This will also be required for IE Tab Multi (Enhance).

@neocotic
Copy link
Member Author

@neocotic neocotic commented Jul 28, 2011

IE Tab Multi (Enhance) only sometimes has [escape] in the query string in which case decodeURIComponent should be called. This appears to happen when accessed via the context menu but may occur at other times (unimportant comment).

Also, it seems that the value of the query string is only populated when first loaded and not updated when the user navigates to another page within the container. I will contact the developer in the hope that this can be changed in an update.

These problems will probably exist in Mozilla Gecko Tab as well as it's made by the same developer.

@neocotic
Copy link
Member Author

@neocotic neocotic commented Jul 28, 2011

This issue has been fixed and additional support has been added.

IE Tab Multi and Mozilla Gecko Tab extensions do not update the URL of the tab as the user navigates to other pages so the URL will always be that which they were originally activated on. I've asked the developer of these extensions to make an update so that new pages are tracked in the URL. This is not something that can be fixed/bypassed on my end so fingers crossed they make the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant