Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default template feature #48

Closed
neocotic opened this issue Nov 8, 2011 · 2 comments
Closed

Add default template feature #48

neocotic opened this issue Nov 8, 2011 · 2 comments
Assignees
Milestone

Comments

@neocotic
Copy link
Member

@neocotic neocotic commented Nov 8, 2011

I've had this idea for a while and the concept is simple so I want to add it for the big release.

An additional option is assigned to each template option to indicate whether or not they are the default. 0 or 1 default template can exist at any time. If a default template exists then the popup doesn't display and the browser action instead triggers that template. This logic should also apply to the context menu, if enabled.

Also, when a default template exists a message should be displayed on the options page explaining what affect this has.

Finally, the keyboard shortcuts of all enabled templates should always be considered.

Optional

Additional options could be added to allow the user to display the icon and/or text in the browser action and context menu to either the default template or that of the extension. Obviously, these settings should only be considered when a default template exists.

@ghost ghost assigned neocotic Nov 8, 2011
neocotic added a commit that referenced this issue Dec 22, 2011
@neocotic neocotic closed this Dec 22, 2011
@neocotic
Copy link
Member Author

@neocotic neocotic commented Jan 25, 2012

Added another option to be considered when the popup is being displayed. This option allows users to specify whether or not the popup should be hidden immediately after a template has been chosen.

Also, as part of #35, I've deprecated most of the options tags included in the initial change for this and added new ones (with better names). The following option tags now exist for this change;

  • toolbarPopup
  • toolbarPopupClose
  • toolbarTemplate
  • toolbarTemplateDetails
  • toolbarTemplateName
@neocotic
Copy link
Member Author

@neocotic neocotic commented Feb 6, 2012

Along with the addition of the toolbarOptions tag (added in #62), the following tags have been changed;

  • toolbarPopupClose renamed to toolbarClose
  • toolbarTemplate removed (used invert of toolbarPopup instead)
  • toolbarTemplateDetails renamed to toolbarStyle
  • toolbarTemplateName renamed to toolbarKey (changed for #58)
@neocotic neocotic added the accepted label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.