Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically save options #60

Closed
neocotic opened this issue Jan 30, 2012 · 2 comments
Closed

Automatically save options #60

neocotic opened this issue Jan 30, 2012 · 2 comments
Assignees
@neocotic
Labels
enhancement
Milestone
1.0.0

Comments

@neocotic
Copy link
Member

Remove the need for the user to click the "Save & Close" button on the options page.

Basically, bind events to automatically persist the corresponding option whenever it is changed. I'm not sure how this will work for changing templates yet but, should performance be an issues, update and/or persist these asynchronously. However, care should be taken for how validation is now performed as some validation was only carried out when the "Save & Close" button was clicked. These will now need to be bound to the relevant fields, and only when they are being changed by the user and not by a change to the list selection.
@ghost ghost assigned neocotic Jan 30, 2012
neocotic added a commit that referenced this issue Jan 30, 2012
@neocotic
first set of changes for #60 including changes to validation
860c967
neocotic added a commit that referenced this issue Jan 30, 2012
@neocotic
second set of changes for #60 - no more save button
5f763d8
neocotic added a commit that referenced this issue Jan 30, 2012
@neocotic
i18n work for #60 changes
a827794
neocotic added a commit that referenced this issue Jan 30, 2012
@neocotic
improved consistency of changes included for #60
4ee0bc3
@neocotic
Copy link
Member Author

I'm happy with these changes but I want to test this more in the Templates section as this is the most complex.

neocotic added a commit that referenced this issue Feb 3, 2012
@neocotic
huge effort for #47 and #60
492f64d
neocotic added a commit that referenced this issue Feb 4, 2012
@neocotic
completed options page for #47 and #60
4a6e3c2
@neocotic
Copy link
Member Author

neocotic commented Feb 6, 2012

I'm really happy with this and can't find any more problems.

@neocotic neocotic closed this as completed Feb 6, 2012
@neocotic neocotic mentioned this issue Mar 20, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocotic neocotic

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@neocotic