Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options link in popup #62

Closed
neocotic opened this issue Feb 2, 2012 · 2 comments
Closed

Options link in popup #62

neocotic opened this issue Feb 2, 2012 · 2 comments
Assignees
Milestone

Comments

@neocotic
Copy link
Member

@neocotic neocotic commented Feb 2, 2012

Add an link to the Options page to the popup after all of the template links. When clicked, either an existing tab showing the options page is selected or it is opened in a new tab.

A new option toolbar.options should be added to enable/disable this link being displayed, but should only be configurable when toolbar.popup is true.

@ghost ghost assigned neocotic Feb 2, 2012
@neocotic
Copy link
Member Author

@neocotic neocotic commented Feb 6, 2012

This has now been implemented and appears to work fine.

@neocotic
Copy link
Member Author

@neocotic neocotic commented Feb 15, 2012

I want to expand on this an make it so that there is also an option to add an Options link to the context menu. To be consistent this will probably involve replacing the contextMenu setting with an object simply called menu with enabled and options as its properties (I'd want to rename the template option for this as well). A new fieldset will be required and the Options Link option should only be visible if context menu is enabled.

Also, I want to change the colour of this link in the popup to a shade of green.

@neocotic neocotic reopened this Feb 15, 2012
neocotic added a commit that referenced this issue Feb 16, 2012
@neocotic neocotic closed this Feb 16, 2012
@neocotic neocotic added the accepted label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.