Skip to content

Commit

Permalink
Added time to the popstate event timeout
Browse files Browse the repository at this point in the history
Apparently, node 0.8 mixes up thread execution order and sometimes the 0ms timeout isn't enough to catch the popstate event.  This caused ```npm test``` to fail.  Interestingly, it did not cause ```test/runner -s window/history.js``` to fail.  Its always scary when issues are not stateless...
  • Loading branch information
Brian Peacock authored and domenic committed Feb 8, 2014
1 parent d9adcb8 commit a0d3e9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/window/history.js
Expand Up @@ -130,5 +130,5 @@ exports["the history object should fire popstate on the window while navigating
t.ok(eventFired, "popstate event should be fired.");
t.strictEqual(state, eventState);
t.done();
}, 0);
}, 10);
};

0 comments on commit a0d3e9e

Please sign in to comment.