This repository has been archived by the owner. It is now read-only.

@message overwraps on value of @reply #4

Closed
koron opened this Issue Dec 29, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@koron
Contributor

koron commented Dec 29, 2012

Open Interactive Demo by Chrome, then input this

@found "App", ->
  @message "Register", "Engine", ->
    @reply "OK"
  @message "Do It", "Engine", ->
    @reply "NG"

Then I got result like this:

overwrap

"Do It" overwraps on "OK", it won't be expected by ordinary user.

tmtk75 added a commit that referenced this issue Dec 31, 2012

@tmtk75

This comment has been minimized.

Show comment
Hide comment
@tmtk75

tmtk75 Dec 31, 2012

Owner

Fixed no later than 10b6c95

Owner

tmtk75 commented Dec 31, 2012

Fixed no later than 10b6c95

@tmtk75 tmtk75 closed this Dec 31, 2012

@koron

This comment has been minimized.

Show comment
Hide comment
@koron

koron Dec 31, 2012

Contributor

@tmtk75 Thanks!

ただ修正コミットはこっちかも 10c1090
コミットメッセージに issue が入ってなければコッチに自動リンクがはられたと思うけど…w

Contributor

koron commented Dec 31, 2012

@tmtk75 Thanks!

ただ修正コミットはこっちかも 10c1090
コミットメッセージに issue が入ってなければコッチに自動リンクがはられたと思うけど…w

@tmtk75

This comment has been minimized.

Show comment
Hide comment
@tmtk75

tmtk75 Dec 31, 2012

Owner

OK, precisely describing about the commits. Fixed at 7e82662 and 10c1090.

Haven't known the auto link in commit message. That's very useful!

Owner

tmtk75 commented Dec 31, 2012

OK, precisely describing about the commits. Fixed at 7e82662 and 10c1090.

Haven't known the auto link in commit message. That's very useful!

tmtk75 added a commit that referenced this issue Jan 1, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.