New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for shell command #103

Merged
merged 1 commit into from Mar 11, 2018

Conversation

Projects
None yet
3 participants
@grimpy
Contributor

grimpy commented Feb 20, 2018

Make it possible to pass window_name and shell command to
server.new_session
Make it possible to pass shell command to window.split_window

Signed-off-by: Jo De Boeck deboeck.jo@gmail.com

@grimpy

This comment has been minimized.

Contributor

grimpy commented Feb 20, 2018

Apprently this implements #87

@codecov-io

This comment has been minimized.

codecov-io commented Feb 20, 2018

Codecov Report

Merging #103 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #103      +/-   ##
========================================
+ Coverage   79.97%    80%   +0.02%     
========================================
  Files           8      8              
  Lines         849    855       +6     
========================================
+ Hits          679    684       +5     
- Misses        170    171       +1
Impacted Files Coverage Δ
libtmux/window.py 83.53% <100%> (+0.2%) ⬆️
libtmux/server.py 77.9% <37.5%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb1dfb...26bdc0d. Read the comment docs.

@tony

This comment has been minimized.

Member

tony commented Feb 24, 2018

Is there any chance this can get a test?

@grimpy

This comment has been minimized.

Contributor

grimpy commented Feb 24, 2018

@grimpy grimpy force-pushed the grimpy:shellcmds branch from 86e9cde to b0fa566 Feb 24, 2018

@grimpy

This comment has been minimized.

Contributor

grimpy commented Feb 24, 2018

Tests added

@tony

This comment has been minimized.

Member

tony commented Mar 4, 2018

Sorry for the late response, I am having issues keeping up with the project. I'm seeking maintainers @ tmux-python/tmuxp#290. If you (or someone you know) may be interested in helping maintain libtmux or tmuxp, feel free to contact me by email or in the tmux-python/tmuxp#290 issue.

@tony tony force-pushed the grimpy:shellcmds branch from b0fa566 to 654ad41 Mar 11, 2018

@tony

This comment has been minimized.

Member

tony commented Mar 11, 2018

I rebased on your behalf to trigger CI (org move, changes). b0fa566 -> 654ad41

@tony

This comment has been minimized.

Member

tony commented Mar 11, 2018

When I rebased via git pull --rebase origin master in your branch and pushed it, the commit shows up differently. The UI no longer shows you signed off on it, though the git commit message is the same. I didn't know that would happen.

Before:
screen shot 2018-03-11 at 3 20 58 pm

After:

screen shot 2018-03-11 at 3 19 25 pm

@tony

This comment has been minimized.

Member

tony commented Mar 11, 2018

I want to do a release today, ideally. I don't have much time during the weekdays.

If this rebase at 654ad41 gets in the way - let me know and I'll force push it out of master and reset things. Though - I'd plan to rebase and merge via GitHub anyway...

Also, if I find that GH doesn't give you credit for the commit - I'm going to revert it to make sure you do.

This is my mistake. I didn't know the PR "add more commits" feature would react that way (i.e. this feature is how I rebased your PR):
screen shot 2018-03-11 at 3 24 05 pm

Add options for shell options
Make it possible to pass window_name and shell command to
server.new_session
Make it possible to pass shell command to window.split_window

Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>

@grimpy grimpy force-pushed the grimpy:shellcmds branch from 654ad41 to 26bdc0d Mar 11, 2018

@grimpy

This comment has been minimized.

Contributor

grimpy commented Mar 11, 2018

@tony don't worry about it, I dont mind not getting the credit I rather have it in the release :)
I did rebase myself and push to my branch it seems to have fixed it though

@tony

This comment has been minimized.

Member

tony commented Mar 11, 2018

I did rebase myself and push to my branch it seems to have fixed it though

That's awesome. :)

@tony tony merged commit 272f3fc into tmux-python:master Mar 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment