Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle next-X.Y versions #172

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@sloria
Copy link
Contributor

commented Jan 25, 2019

tmuxp currently crashes when used with
tmux next-2.9 (the latest Homebrew release).

TypeError: '<' not supported between instances of 'str' and 'int'

This patch avoids the error by making get_version()
strip the "next-" part of the version.

closes tmux-python/tmuxp#449

Handle next-X.Y versions
tmuxp currently crashes when used with
tmux next-2.9 (the latest Homebrew release).

```
TypeError: '<' not supported between instances of 'str' and 'int'
```

This patch avoids the error by making `get_version()`
strip the "next-" part of the version.

closes tmux-python/tmuxp#449
@codecov-io

This comment has been minimized.

Copy link

commented Jan 25, 2019

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   79.49%   79.49%           
=======================================
  Files           8        8           
  Lines         863      863           
=======================================
  Hits          686      686           
  Misses        177      177
Impacted Files Coverage Δ
libtmux/common.py 86.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9097c31...f870a84. Read the comment docs.

@tony tony merged commit f9491e9 into tmux-python:master Jan 25, 2019

3 checks passed

codecov/patch 100% of diff hit (target 79.49%)
Details
codecov/project 79.49% (+0%) compared to 9097c31
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

@sloria Thank you!

@sloria sloria deleted the sloria:handle-next-versions branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.