Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session id to Session cmds, when appropriate #65

Merged
merged 4 commits into from Aug 18, 2017

Conversation

@askedrelic
Copy link
Contributor

@askedrelic askedrelic commented Aug 8, 2017

Starting on fixing #64.

@tony
Copy link
Member

@tony tony commented Aug 9, 2017

Let's try to take the approach where we smooth out the *args (#64 (comment)). We can use += instead of .extends( to avoid an extra function call (#64 (comment)).

@askedrelic askedrelic force-pushed the askedrelic:add-kwargs-to-tmux-cmd branch from 541ad0c to 22f7ea8 Aug 15, 2017
@askedrelic
Copy link
Contributor Author

@askedrelic askedrelic commented Aug 15, 2017

So I rebased my code to use += to add the session id, if it is not set. It's a little more complicated due to tmux requiring the -t arg be in a specific position, but the test suite should be passing!

@askedrelic askedrelic changed the title Working adding kwargs to tmux_cmd Add session id to Session cmds, when appropriate Aug 15, 2017
@askedrelic
Copy link
Contributor Author

@askedrelic askedrelic commented Aug 16, 2017

Hmm looks like tests broke due to Py3. I'm still using Py2 as my main environment, I will take a look!

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 16, 2017

Codecov Report

Merging #65 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   79.97%   80.07%   +0.09%     
==========================================
  Files           8        8              
  Lines         844      848       +4     
==========================================
+ Hits          675      679       +4     
  Misses        169      169
Impacted Files Coverage Δ
libtmux/session.py 81.09% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6df234...a9bf0a5. Read the comment docs.

@tony tony merged commit 6811ba4 into tmux-python:master Aug 18, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tony
Copy link
Member

@tony tony commented Aug 18, 2017

@askedrelic nice job!

@askedrelic
Copy link
Contributor Author

@askedrelic askedrelic commented Aug 19, 2017

Hooray, thanks for the merge @tony 🎊

@askedrelic askedrelic deleted the askedrelic:add-kwargs-to-tmux-cmd branch Aug 19, 2017
@tony
Copy link
Member

@tony tony commented Aug 20, 2017

released in v0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants