Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite doesn't pass under OS X #26

Closed
stratoukos opened this issue Dec 3, 2013 · 4 comments
Closed

test suite doesn't pass under OS X #26

stratoukos opened this issue Dec 3, 2013 · 4 comments
Assignees
Milestone

Comments

@stratoukos
Copy link

@stratoukos stratoukos commented Dec 3, 2013

FocusAndPaneIndexTest and PaneOrderingTest in test_workspacebuilder.py fail to pass under OS X for 2 reasons:

  1. /sys does not exist in OS X
  2. /var is symlinked to /private/var and pane.get('pane_current_path') returns the resolved path, so assertEqual fails with AssertionError: u'/private/var' != '/var'. The same also stands for /tmp.

I tried to fix this, either by manually resolving the paths in the test case with os.path.realpath, or by changing the paths in the test case and the yaml configuration to /usr. In both cases there were some weird issues with running the tests.

When I run one of the failing tests alone, it works with either fix. If I run the whole suite, the test cases failed randomly (not always!) because pane.get('pane_current_path') returned either my cwd (the root of the repo) or my home directory.

@ghost ghost assigned tony Dec 3, 2013
@tony
Copy link
Member

@tony tony commented Dec 3, 2013

@stratoukos Thank you for this. I don't have OS X, but I will follow up.

1.) There is no reason to be using /sys/, /var and etc. I will apply into not using those directories as examples and test cases.
2.) Tests failing. I experience similar behavior too, this is because the asynchronous nature of the test. I am going to look into increasing the time.

Are you using the git / development version? I will reference my fixes to this issue.

tony added a commit that referenced this issue Dec 3, 2013
tony added a commit that referenced this issue Dec 3, 2013
tony added a commit that referenced this issue Dec 3, 2013
tony added a commit that referenced this issue Dec 3, 2013
@tony
Copy link
Member

@tony tony commented Dec 3, 2013

@stratoukos can you give the latest git a shot?

@stratoukos
Copy link
Author

@stratoukos stratoukos commented Dec 3, 2013

Yes I was working off master. I will give it another shot tomorrow morning.

@stratoukos
Copy link
Author

@stratoukos stratoukos commented Dec 4, 2013

There was still /tmp in there, but everything else worked ok

@tony tony closed this in #29 Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.