Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server.attached_sessions return type #107

Merged
merged 2 commits into from Jul 3, 2015

Conversation

@thomasballinger
Copy link
Contributor

@thomasballinger thomasballinger commented Jun 29, 2015

No description provided.

@thomasballinger
Copy link
Contributor Author

@thomasballinger thomasballinger commented Jun 29, 2015

Server.attached_sessions was documented to return a tmux session object or None but was returning a list of session dicts or None.

@thomasballinger
Copy link
Contributor Author

@thomasballinger thomasballinger commented Jun 29, 2015

It's not clear to me what the right fix is (the note in the docs makes it sound like maybe the list will only every be length 1?) but was going to raise an issue and thought I'd take a whack at it instead.

@tony
Copy link
Member

@tony tony commented Jul 2, 2015

@thomasballinger Greetings!

Nice, I'm taking a look! Can you rebase this so the tests run? I want to be sure it doesn't cause any regressions on older tmux versions.

@tony
Copy link
Member

@tony tony commented Jul 2, 2015

I made a change at 150fd9c to fix travis tests.

@thomasballinger thomasballinger force-pushed the thomasballinger:fix-attached-sessions branch from 26c2c61 to 75d5d6b Jul 2, 2015
tony added a commit that referenced this pull request Jul 3, 2015
Fix Server.attached_sessions return type
@tony tony merged commit 6d68dab into tmux-python:master Jul 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony
Copy link
Member

@tony tony commented Jul 3, 2015

Nice @thomasballinger, you're becoming the tmuxp master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.