New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import root folder from tmuxinator #159

Merged
merged 1 commit into from May 29, 2016

Conversation

Projects
None yet
3 participants
@fpietka
Contributor

fpietka commented May 29, 2016

Seems config import was only importing project_root part.

Updated the tests to reflect that change.

@coveralls

This comment has been minimized.

coveralls commented May 29, 2016

Coverage Status

Coverage increased (+0.2%) to 50.621% when pulling 494c8d5 on fpietka:import/tmuxinator into ccccebe on tony:master.

@tony

This comment has been minimized.

Member

tony commented May 29, 2016

I think we may be in a better situation if tmuxp just loads tmuxinator configs natively, any opinion on that?

@tony tony merged commit 07cd773 into tmux-python:master May 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 50.621%
Details
@tony

This comment has been minimized.

Member

tony commented May 29, 2016

Looks good. Any other tmuxinator compatibility stuff we could put in there?

@fpietka

This comment has been minimized.

Contributor

fpietka commented May 29, 2016

reading tmuxinator configuration natively would be a nice feature indeed.

also it's worth mentioning few nice addition (although not compatibility issues):

  • ~/.tmuxinator/ folder could be part of the path we're looking into by default
  • yml/yaml extension could be omitted (but it could be not limited to import ;) )
@tony

This comment has been minimized.

Member

tony commented May 29, 2016

yml/yaml extension could be omitted (but it could be not limited to import ;) )

as in, the file would still be yaml or yml, but it wouldn't require typing the full filename to load it?

@fpietka

This comment has been minimized.

Contributor

fpietka commented May 29, 2016

yes, and more generally so we can type tmuxp load myproject to load myproject.yaml

@tony

This comment has been minimized.

Member

tony commented May 29, 2016

i like the idea

can you make an issue for it?

@fpietka

This comment has been minimized.

Contributor

fpietka commented May 29, 2016

done (#160)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment