New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bash prompt when comparing history command. #193

Merged
merged 1 commit into from Dec 2, 2016

Conversation

Projects
None yet
3 participants
@abeyer
Contributor

abeyer commented Dec 1, 2016

The sent_cmd includes the bash prompt on the captured line (or at
least could depending on timing) so compare with endswith() to ignore
any prefix containing the prompt string.

Ignore bash prompt when comparing history command.
The `sent_cmd` includes the bash prompt on the captured line (or at
least could depending on timing) so compare with `endswith()` to ignore
any prefix containing the prompt string.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 1, 2016

Current coverage is 83.28% (diff: 100%)

Merging #193 into master will not change coverage

@@             master       #193   diff @@
==========================================
  Files             5          5          
  Lines           742        742          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            618        618          
  Misses          124        124          
  Partials          0          0          

Powered by Codecov. Last update 10f90e3...41319a1

@tony tony merged commit 86dc30a into tmux-python:master Dec 2, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 10f90e3...41319a1
Details
codecov/project 83.28% (+0.00%) compared to 10f90e3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony

This comment has been minimized.

Member

tony commented Dec 2, 2016

Looks good, nice catch @abeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment