New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get config_dir from env TMUXP_CONFIG_DIR or TMUXP_DIR #207

Merged
merged 6 commits into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@Ilyes512
Contributor

Ilyes512 commented Jan 31, 2017

This make the tmuxp config dir configurable by setting env variables TMUXP_CONFIG_DIR or TMUXP_DIR.

@codecov-io

This comment has been minimized.

codecov-io commented Jan 31, 2017

Codecov Report

Merging #207 into master will increase coverage by 0.04%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   83.82%   83.87%   +0.04%     
==========================================
  Files           5        5              
  Lines         742      744       +2     
==========================================
+ Hits          622      624       +2     
  Misses        120      120
Impacted Files Coverage Δ
tmuxp/cli.py 65.27% <100%> (+0.24%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab1f17...3805520. Read the comment docs.

@Ilyes512

This comment has been minimized.

Contributor

Ilyes512 commented Feb 4, 2017

Any feedback?

tony added some commits Feb 6, 2017

return os.path.expanduser(os.environ['TMUXP_CONFIG_DIR'])
if 'TMUXP_DIR' in os.environ:
if 'TMUXP_CONFIGDIR' in os.environ:
return os.path.expanduser(os.environ['TMUXP_DIR'])

This comment has been minimized.

@Ilyes512

Ilyes512 Feb 6, 2017

Contributor

You know check for TMUXP_CONFIGDIR and then read the value of TMUXP_DIR.

tony added some commits Feb 7, 2017

@tony tony merged commit ca6e6c1 into tmux-python:master Feb 7, 2017

3 checks passed

codecov/patch 100% of diff hit (target 83.82%)
Details
codecov/project 83.87% (+0.04%) compared to 8ab1f17
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ilyes512

This comment has been minimized.

Contributor

Ilyes512 commented Feb 7, 2017

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment