Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `options_after` window option #235

Merged
merged 6 commits into from Apr 24, 2017

Conversation

@sebastianst
Copy link
Contributor

@sebastianst sebastianst commented Apr 11, 2017

Created new method config_after_window() that applies relevant configurations after windows and panes have been created.

Currently, it only knows the options_after option. This is useful for setting synchronize-panes: on after pane creation and shell command execution.

The same could be done for panes, but I don't know of an application for that at the moment.

Created new method config_after_window() that applies relevant
configurations after windows and panes have been created. Currently, it
only knows the `options_after` option.
This is useful for setting `synchronize-panes: on` *after* pane
creation and shell command execution.
@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 11, 2017

This solves issue #234

@codecov-io
Copy link

@codecov-io codecov-io commented Apr 11, 2017

Codecov Report

Merging #235 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #235     +/-   ##
=========================================
+ Coverage   83.57%   83.68%   +0.1%     
=========================================
  Files           5        5             
  Lines         749      754      +5     
=========================================
+ Hits          626      631      +5     
  Misses        123      123
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 95.67% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634974c...648171d. Read the comment docs.

@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 11, 2017

sh of Travis CI interpretes the Up key sent by libtmux as ^[[A instead of repeating the last command... It worked on my machine. What would be the best way to test the last input command in Travis CI, if not in /bin/sh with cmd('send-keys', 'Up')?

@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 12, 2017

It was quite some effort to get the tests working on Travis. Because of slow execution of the echo commands, I had to use the trick from test_suppress_history with a sleep(.1) loop to make them work. Also, tmux 1.8 has a bug apparently by which capture-pane has trailing empty lines...
Now the tests go through. The included commits were actually squashed from 9 commits until I got it working on my CI testing branch.

@tony tony added the enhancement label Apr 17, 2017
@tony tony self-requested a review Apr 17, 2017
@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 21, 2017

Sure, will do next week!

Example shows how to ssh into two different servers with synchronized
panes.
@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 24, 2017

Done. The example shows how to ssh into two different servers with synchronized
panes.

@tony tony merged commit 6eabe5e into tmux-python:master Apr 24, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 83.57%)
Details
codecov/project 83.68% (+0.1%) compared to 634974c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony
Copy link
Member

@tony tony commented Apr 24, 2017

Nice job @sebastianst!

@tony
Copy link
Member

@tony tony commented Apr 28, 2017

This is now live in 1.3.0

@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 28, 2017

Great, thank you!

@sebastianst sebastianst deleted the sebastianst:feat-options_after branch Apr 28, 2017
@sebastianst
Copy link
Contributor Author

@sebastianst sebastianst commented Apr 28, 2017

One question on the release though: The github latest release is still set to 1.2.1 - is that intentional?

@tony
Copy link
Member

@tony tony commented Apr 28, 2017

Nope, it's about 8 or so releases behind.
screen shot 2017-04-28 at 5 57 06 pm

I just don't update releases, the main ways of grabbing it are pypi, git (via master or the tag) or a package manager.

That said, I went ahead and issued a 1.3.0 released.

@tony
Copy link
Member

@tony tony commented Apr 28, 2017

You can see the release notes at https://tmuxp.git-pull.com/en/latest/history.html

@tony
Copy link
Member

@tony tony commented Apr 28, 2017

Also, in c7b2cc7, I had to fix the link to this issue in CHANGES. That should be live on the docs in a few minutes. You may have to hard refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.