New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading, get the config canonical file path #236

Merged
merged 2 commits into from Apr 26, 2017

Conversation

Projects
None yet
3 participants
@rafi
Contributor

rafi commented Apr 17, 2017

Fix issue when config files are symlinks in ~/.tmuxp.

For example,

$ tree ~/.tmuxp
/Users/bob/.tmuxp
├── hooray-api.yml -> /Users/bob/code/python/hooray/api/.tmuxp.yml
└── hooray-web.yml -> /Users/bob/code/python/hooray/web/.tmuxp.yml

Once loaded, it is expected for /Users/bob/code/python/hooray/... to be the current directory, specially when using start_directory: ./ within the configuration file.
Before this patch, the current directory will improperly resolve to /Users/bob/.tmuxp.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 17, 2017

Codecov Report

Merging #236 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #236      +/-   ##
=========================================
- Coverage   83.68%   83.6%   -0.09%     
=========================================
  Files           5       5              
  Lines         754     750       -4     
=========================================
- Hits          631     627       -4     
  Misses        123     123
Impacted Files Coverage Δ
tmuxp/cli.py 64.84% <100%> (+0.12%) ⬆️
tmuxp/workspacebuilder.py 95.54% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eabe5e...1dc1f49. Read the comment docs.

@tony

This comment has been minimized.

Member

tony commented Apr 20, 2017

@rafi

This comment has been minimized.

Contributor

rafi commented Apr 23, 2017

@tony thanks for the pointers, added a test.

rafi added some commits Apr 17, 2017

When loading, get the config canonical file path
Fix issue when config files are symlinks in `~/.tmuxp`

@tony tony force-pushed the rafi:fix/symlinks branch from be9d239 to 1dc1f49 Apr 26, 2017

@tony tony merged commit 643b2b2 into tmux-python:master Apr 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony

This comment has been minimized.

Member

tony commented Apr 28, 2017

This is now live in v1.3.0

@rafi rafi deleted the rafi:fix/symlinks branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment