New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with start_directory containing spaces #73

Merged
merged 7 commits into from Apr 1, 2014

Conversation

Projects
None yet
2 participants
@ThiefMaster
Contributor

ThiefMaster commented Mar 30, 2014

The way you are passing arguments to the shell commands makes escaping of arguments unnecessary and doing so anyway breaks things. Also, the start_directory testcase was pretty broken and did not test if the correct directory was used.

@tony

This comment has been minimized.

Member

tony commented Mar 31, 2014

@ThiefMaster: Thanks for this, start_directory can be pretty picky, so making it more robust and stable is good.

Can you take a look over https://travis-ci.org/tony/tmuxp/builds/21901819?

@ThiefMaster

This comment has been minimized.

Contributor

ThiefMaster commented Apr 1, 2014

Ugh, seems like tmux 1.8 and 1.9+ handle the start dir argument differently.. I'll have a look later when I'm not at work.

@ThiefMaster

This comment has been minimized.

Contributor

ThiefMaster commented Apr 1, 2014

Ok, they removed pane_start_path in 1.9 but failed to document it or remove it from the manpage. Updated the testcase to use pane_current_path instead.

@tony

This comment has been minimized.

Member

tony commented Apr 1, 2014

@ThiefMaster : Thank gosh tmuxp has a testcases against multiple versions of tmux that actually asserts changes.

tony added a commit that referenced this pull request Apr 1, 2014

Merge pull request #73 from ThiefMaster/startdir-spaces
Fix errors with start_directory containing spaces

@tony tony merged commit 8a75cd6 into tmux-python:master Apr 1, 2014

1 check passed

default The Travis CI build passed
Details

tony added a commit that referenced this pull request Apr 1, 2014

@ThiefMaster ThiefMaster deleted the ThiefMaster:startdir-spaces branch Apr 2, 2014

@ThiefMaster ThiefMaster restored the ThiefMaster:startdir-spaces branch Apr 2, 2014

tony added a commit that referenced this pull request Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment