Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require shell_command #76

Merged
merged 1 commit into from Apr 1, 2014
Merged

don't require shell_command #76

merged 1 commit into from Apr 1, 2014

Conversation

@ThiefMaster
Copy link
Contributor

@ThiefMaster ThiefMaster commented Apr 1, 2014

Right now this fails:

    panes:
      - focus: true

while this works:

    panes:
      - focus: true
        shell_command:

or this:

    panes:
      -

It would be nice if shell_command defaulted to empty even if other keys were present for the pane.

@tony
Copy link
Member

@tony tony commented Mar 31, 2014

@ThiefMaster: thanks for the report!

So http://tmuxp.readthedocs.org/en/latest/examples.html#blank-panes do not work focus: true?

If I did

ession_name: Blank pane test
windows:
  # Emptiness will simply open a blank pane, if no shell_command_before.
  # All these are equivalent
  - window_name: Blank pane test
    panes:
    -
    - pane
    - blank
      focus: true

that wouldn't work?

@ThiefMaster
Copy link
Contributor Author

@ThiefMaster ThiefMaster commented Apr 1, 2014

    - blank
      focus: true

That's invalid YAML - a plain - blank works because that way you get a string value. But with the focus: true below you get an object so blank is a syntax error because there's no : value afterwards.

fixes #76
tony added a commit that referenced this pull request Apr 1, 2014
don't require shell_command
@tony tony merged commit 0c38e58 into tmux-python:master Apr 1, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
tony added a commit that referenced this pull request Apr 1, 2014
@ThiefMaster ThiefMaster deleted the ThiefMaster:shell-command-optional branch Apr 2, 2014
@ThiefMaster ThiefMaster restored the ThiefMaster:shell-command-optional branch Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.