New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve choose-tree navigation #1080

Closed
non opened this Issue Sep 18, 2017 · 5 comments

Comments

5 participants
@non

non commented Sep 18, 2017

In tmux 2.6-rc3, choose-window is now implemented via choose-tree.

Previously, I was able to navigate the choose-window list using C-p and C-n (Emacs' up and down bindings). I noticed that after an upgrade to 2.6-rc3 this no longer works. It seems like the choose-tree bindings are different than those from choose-window. I confirmed in Vanilla tmux 2.5 that this works as I had expected.

I can imagine several possible fixes:

  1. Add these bindings to choose-tree.
  2. Add an option to add these bindings to choose-tree.
  3. Make one of the existing editor options (e.g. mode-keys) also add these bindings to choose tree when in Emacs mode.

(Not sure you'll need this info but: I'm running Linux, TERM is screen-256color (within tmux) and xterm-256color (outside of tmux).)

@nicm

This comment has been minimized.

Show comment
Hide comment
@nicm

nicm Sep 25, 2017

Contributor

I would be OK with having these as builtin keys.

Contributor

nicm commented Sep 25, 2017

I would be OK with having these as builtin keys.

@nicm nicm added the after-2.6 label Sep 27, 2017

@nicm nicm removed the after-2.6 label Oct 5, 2017

@ght

This comment has been minimized.

Show comment
Hide comment
@ght

ght Oct 6, 2017

Maybe use the same bindings in choose-tree as in copy-mode (cursor-up, cursor-down, history-top, history-bottom, vi type repeat prefixes, etc.) to keep them consistent and configurable (emacs/vi).

I just noticed that while j/k work in choose-tree, g/G do not, instead C-b/C-f go to the first/last line, despite usually being bound to cursor-left/cursor-right.

Also collapsing/expanding the pane list of sessions with space does not seem to work any more either.

The new preview feature is really nice, keep up the great work.

ght commented Oct 6, 2017

Maybe use the same bindings in choose-tree as in copy-mode (cursor-up, cursor-down, history-top, history-bottom, vi type repeat prefixes, etc.) to keep them consistent and configurable (emacs/vi).

I just noticed that while j/k work in choose-tree, g/G do not, instead C-b/C-f go to the first/last line, despite usually being bound to cursor-left/cursor-right.

Also collapsing/expanding the pane list of sessions with space does not seem to work any more either.

The new preview feature is really nice, keep up the great work.

@nicm

This comment has been minimized.

Show comment
Hide comment
@nicm

nicm Oct 11, 2017

Contributor

Added C-p and C-n now, thanks.

Contributor

nicm commented Oct 11, 2017

Added C-p and C-n now, thanks.

@nicm nicm closed this Oct 11, 2017

@tbrand

This comment has been minimized.

Show comment
Hide comment
@tbrand

tbrand Oct 25, 2017

I would like to see full .tmux.conf about the option since I'm new-comer for tmux.
Could you show me how to add emacs like key binds in choose-tree mode?

Thanks!

tbrand commented Oct 25, 2017

I would like to see full .tmux.conf about the option since I'm new-comer for tmux.
Could you show me how to add emacs like key binds in choose-tree mode?

Thanks!

@xuxiangyang

This comment has been minimized.

Show comment
Hide comment
@xuxiangyang

xuxiangyang Mar 15, 2018

Hi,I saw this feature was add in this 99351c9 commit, but this commit is done after 2.6. When the 2.7 will be released? Need this feature so much. thx

xuxiangyang commented Mar 15, 2018

Hi,I saw this feature was add in this 99351c9 commit, but this commit is done after 2.6. When the 2.7 will be released? Need this feature so much. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment