Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command length limited not documented #254

Closed
ole-tange opened this issue Jan 1, 2016 · 3 comments

Comments

@ole-tange
Copy link

@ole-tange ole-tange commented Jan 1, 2016

There is a limit on the length on the command. This limit should either be removed (preferred) or documented in the man page:

$ tmux1.8 new-session -d echo' '"`yes | head -c 2028`"
OK 
$ tmux1.8 new-session -d echo' '"`yes | head -c 2029`"
command too long

$ tmux1.9 new-session -d echo' '"`yes | head -c 16344`"
OK
$ tmux1.9 new-session -d echo' '"`yes | head -c 16345`"
failed to send command
@ThomasAdam

This comment has been minimized.

Copy link
Contributor

@ThomasAdam ThomasAdam commented Jan 1, 2016

I don't see this as a problem, and this is something most people shouldn't be hitting anyway.

@krader1961

This comment has been minimized.

Copy link

@krader1961 krader1961 commented Jan 1, 2016

I agree that this isn't a problem in practice. A 2KB command buffer should be more than enough. These are supposed to be commands a human would type interactively at a shell; not entire scripts. And removing the limit complicates the code and just shifts the problem. What happens when someone does something really stupid and attempts to send a "command" several hundred megabytes in length? Having said that it would be a good idea to document the limit; preferably with a rationale like the one I mentioned earlier.

@nicm

This comment has been minimized.

Copy link
Member

@nicm nicm commented Jan 15, 2016

I don't feel particularly strongly that this needs to be documented but if someone sends a change I'll look at it.

@nicm nicm closed this Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.