Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement router sharding support #69

Closed
wants to merge 3 commits into from
Closed

Conversation

@tanskann
Copy link

@tanskann tanskann commented Jun 19, 2018

Fixes #45 by making it possible to configure labels to challenge URL

@tanskann
Copy link
Author

@tanskann tanskann commented Aug 8, 2018

Seems to me that the build is triggered for go version go1.7.4 linux/amd64 which I guess is unwanted. By fixing the CI it should show green light.

Same thing happening with current open pull requests.

@aramalipoor
Copy link

@aramalipoor aramalipoor commented Oct 20, 2018

Any updates on this?

@foosinn
Copy link

@foosinn foosinn commented Jan 9, 2019

i would also like to see this merged. is there anything we can help with?

@openshift-merge-robot
Copy link
Collaborator

@openshift-merge-robot openshift-merge-robot commented Feb 6, 2019

/retest

1 similar comment
@openshift-merge-robot
Copy link
Collaborator

@openshift-merge-robot openshift-merge-robot commented Feb 6, 2019

/retest

@tnozicka
Copy link
Owner

@tnozicka tnozicka commented Mar 21, 2019

/ok-to-test
/retest

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Jun 19, 2019

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@tanskann
Copy link
Author

@tanskann tanskann commented Jun 19, 2019

/retest

@tnozicka
Copy link
Owner

@tnozicka tnozicka commented Jun 20, 2019

Conflicting files
pkg/cmd/cmd.go

this conflict needs to be solved first, or the test keep failing

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Jul 20, 2019

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@LorbusChris
Copy link

@LorbusChris LorbusChris commented Jul 30, 2019

@tanskann would you mind rebasing?
/remove-lifecycle rotten

@tanskann
Copy link
Author

@tanskann tanskann commented Jul 31, 2019

@LorbusChris I'll try to find some time this week

@openshift-ci-robot
Copy link
Collaborator

@openshift-ci-robot openshift-ci-robot commented Jul 31, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanskann
To complete the pull request process, please assign tnozicka
You can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

@openshift-ci-robot openshift-ci-robot commented Jul 31, 2019

@tanskann: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 283396a link /test e2e
ci/prow/e2e-single-namespace 7d30ae0 link /test e2e-single-namespace

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Oct 29, 2019

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-bot
Copy link

@openshift-bot openshift-bot commented Nov 28, 2019

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@LorbusChris
Copy link

@LorbusChris LorbusChris commented Nov 29, 2019

/remove-lifecycle rotten

@tnozicka
Copy link
Owner

@tnozicka tnozicka commented Dec 3, 2019

v2 rewrite in #92 deep copies the original route so it gets any labels set on the original route - I think that should cover the use case, right?

We also don't get successful CI runs until that's merged as LE disabled staging and now also live v1 registrations.

As I think #92 fixes the issue and also outdated the code modified here, I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants